Prepare for FQDN unique names: controller-0 match #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
cjeanner
force-pushed
the
playbooks/match-controller-name
branch
from
489bffb
to
b21adcd
Compare
cjeanner
force-pushed
the
playbooks/match-controller-name
branch
from
b21adcd
to
34c6148
Compare
We'll have to use FQDN, unique names for the deployment at some point. This PR slightly modifies how we extract controller-0 related data from the hostvars, in order to prepare for the FQDN integration (there's a good chance the inventory will get updated). It also introduces a try/catch schema to provide hopefully useful output in case of failure.
cjeanner
force-pushed
the
playbooks/match-controller-name
branch
from
34c6148
to
974a0d4
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll have to use FQDN, unique names for the deployment at some point.
This PR slightly modifies how we extract controller-0 related data from
the hostvars, in order to prepare for the FQDN integration (there's a
good chance the inventory will get updated).
It also introduces a try/catch schema to provide hopefully useful output
in case of failure.
As a pull request owner and reviewers, I checked that: