-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _openstack_final_env to set final env filename #2191
Conversation
Skipping CI for Draft Pull Request. |
Currently we store all the operator env variables in operator_env.txt. Since this role is used twice in update job. We need a var to store the env variable before update and after update. cifmw_set_openstack_containers_openstack_final_env will help to achieve the same. Signed-off-by: Chandan Kumar <[email protected]>
7da13cd
to
5e0c20f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a thought on the consistency of the default?
/cherry-pick 18.0.0-proposed |
@raukadah: new pull request created: #2195 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Currently we store all the operator env variables in operator_env.txt.
Since this role is used twice in update job. We need a var to store the env variable before update and after update.
cifmw_set_openstack_containers_openstack_final_env will help to achieve the same.
As a pull request owner and reviewers, I checked that: