Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _openstack_final_env to set final env filename #2191

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented Aug 2, 2024

Currently we store all the operator env variables in operator_env.txt.

Since this role is used twice in update job. We need a var to store the env variable before update and after update.

cifmw_set_openstack_containers_openstack_final_env will help to achieve the same.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

Copy link
Contributor

openshift-ci bot commented Aug 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Currently we store all the operator env variables in operator_env.txt.

Since this role is used twice in update job. We need a var to store
the env variable before update and after update.

cifmw_set_openstack_containers_openstack_final_env will help to achieve
the same.

Signed-off-by: Chandan Kumar <[email protected]>
@raukadah raukadah marked this pull request as ready for review August 2, 2024 11:59
Copy link
Contributor

@ciecierski ciecierski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ciecierski ciecierski added the minor update Changes for minor update automation label Aug 5, 2024
@son-vyas son-vyas added the lgtm label Aug 5, 2024
@son-vyas
Copy link
Contributor

son-vyas commented Aug 5, 2024

/lgtm

Copy link
Contributor

@rebtoor rebtoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 5, 2024
Copy link
Contributor

@marios marios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a thought on the consistency of the default?

roles/set_openstack_containers/README.md Show resolved Hide resolved
@openshift-merge-bot openshift-merge-bot bot merged commit 27b1634 into main Aug 5, 2024
10 of 11 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the set_openstack_containers branch August 5, 2024 09:22
@raukadah
Copy link
Contributor Author

raukadah commented Aug 5, 2024

/cherry-pick 18.0.0-proposed

@openshift-cherrypick-robot

@raukadah: new pull request created: #2195

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm minor update Changes for minor update automation Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants