-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow set debug mode for Tempest #2307
base: main
Are you sure you want to change the base?
Allow set debug mode for Tempest #2307
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the PR! ❤️ |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b7b0bc76af8d4520af00e8b5bb93a6fa ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 01s |
recheck Thanks, looks good to me 👍 . I see no reason why not to expose this parameter. The job failure does not seem to be related to the patch:
|
recheck |
This change allows to enable the debug mode for the Tempest test operator by setting `cifmw_test_operator_tempest_debug: true` in spec (false by default). It must only be set to true for debbuging purposes (e.g. when running the operator manually) because it keeps the pod (e.g .Running) sleeping infinity.
6a5d907
to
d8cb493
Compare
@@ -87,6 +87,7 @@ cifmw_tempest_tempestconf_config_defaults: | |||
enforce_scope = false | |||
|
|||
# Please refer to https://openstack-k8s-operators.github.io/test-operator/guide.html#executing-tempest-tests | |||
cifmw_test_operator_tempest_debug: false | |||
cifmw_test_operator_tempest_config: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a proper data structure, I'm wondering if we shouldn't:
- push a
cifmw_test_operator_tempest_default_config
invars/main.yml
- update
cifmw_test_operator_tempest_config
to be mostly empty - combine both dict before generating the configuration file
That way, we could get something really nice and provide a better interface. Avoiding that kind of PR.
Any thoughts?
This change allows to enable the debug mode for the Tempest test operator by setting
cifmw_test_operator_tempest_debug: true
in spec (false by default). It must only be set to true for debbuging purposes (e.g. when running the operator manually) because it keeps the pod (e.g .Running) sleeping infinity.