Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ceph update if part of the deployment #2349

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Sep 13, 2024

In case we perform a minor update job where Ceph is deployed, as part of the minor update procedure we might want to update Ceph (according to a given container image tag) to verify the combination between the target Ceph version and the target OpenStack version is still healthy. This patch introduces the tasks that are supposed to call the Ceph update before OpenStack:

  • it results in a noop in case the ceph container image tag is the <= of the current deployed Ceph cluster
  • it is skipped by default if no ceph_update variable is passed or it is set to false
  • it can be skipped by passing --skip-tags ceph_update to the playbook

By doing this we have the ability to trigger a Ceph update and make sure we continue to test the combination between the two projects, but at the same time we are not introducing an hard dependency as it can easily be skipped.

Jira: https://issues.redhat.com/browse/OSPRH-9697

Copy link
Contributor

openshift-ci bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cescgina for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot marked this pull request as draft September 13, 2024 13:07
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@fmount
Copy link
Contributor Author

fmount commented Sep 13, 2024

I'd like to testproject this before doing any change or marking as ready.

@fmount fmount requested a review from fultonj September 13, 2024 13:16
@ciecierski ciecierski added the minor update Changes for minor update automation label Sep 13, 2024
In case we perform a minor update job where Ceph is deployed, as part of
the minor update procedure we might want to update Ceph (according to a
given container tag) to verify the combination between the target Ceph
version and the target RHOSO version is still healthy.
This patch introduces the tasks that are supposed to call the Ceph
update before openstack:
- it results in a noop in case the ceph container image tag is the <= of
  the current deployed Ceph cluster
- it is skipped by default if no "ceph_update" variable is passed or it
  is set to false
- it can be skipped by passing --skip-tags ceph_update to the playbook

By doing this we have the ability to trigger a Ceph update and make sure
we continue to test the combination between the two projects, but at the
same time we are not introducing an hard dependency as it can easily be
skipped.

Jira: https://issues.redhat.com/browse/OSPRH-9697

Signed-off-by: Francesco Pantano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants