Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Ironic baremetal net in a dedicated ci-bootstrap job #2371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add the Ironic baremetal net in a dedicated ci-bootstrap job #2371

wants to merge 1 commit into from
+60 −65

Conversation

pablintino
Copy link
Collaborator

@pablintino pablintino commented Sep 23, 2024 •
edited by lewisdenny
Loading

  • Add debugging playbook to manually fail job
  • Add new node set locked to Vexxhost as currently ci-bootstrap won't
    work on IBM cloud
  • Add new job to test Ironic

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 2371,162082f31b353e4503630c591dc575b9e18626bc

@pablintino pablintino force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from 162082f to a65855a Compare September 23, 2024 15:50
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/29e0030891f441eb9aa1fe1d7722e55e

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-ironic FAILURE in 30m 14s

@lewisdenny lewisdenny force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from a65855a to 0407940 Compare September 24, 2024 03:33
@lewisdenny
Copy link
Collaborator

recheck

@pablintino pablintino force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from 0407940 to fc5e28c Compare September 24, 2024 13:36
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fc960dba137a4e1c9f6d133cbfcc5900

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-ironic FAILURE in 22m 29s

@pablintino pablintino force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from fc5e28c to 507d543 Compare September 24, 2024 15:17
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/30effd5608fa474380397ae470c9a5fb

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-ironic RETRY_LIMIT in 10m 33s

@pablintino
Copy link
Collaborator Author

recheck

1 similar comment
@pablintino
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/40d0adba9066488a8aaebfcdb25f09b8

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-ironic RETRY_LIMIT in 10m 01s

@pablintino pablintino force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch 2 times, most recently from fecbceb to d2399a4 Compare September 24, 2024 15:53
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/88eafd5a1fa841ff9a748f36345cc6b0

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 7m 24s

@pablintino pablintino force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from d2399a4 to e659134 Compare September 24, 2024 16:04
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c88e6bfcfbcf4f0db8808572cb6f115c

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 7m 33s

@pablintino pablintino force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from e659134 to 70e1e35 Compare September 24, 2024 16:15
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f47d1286ffb140f5a98b0ecbc1f9387d

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 7m 59s

@pablintino pablintino force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from 70e1e35 to fc64922 Compare September 24, 2024 16:30
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d390edc8b1824ab5ada25ecb37b27cce

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 8m 08s

@pablintino pablintino force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from fc64922 to 9ddbb8c Compare September 24, 2024 16:49
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9e60cf0cc18242f19278645716eb1d9b

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 8m 05s

@lewisdenny lewisdenny force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from 9ddbb8c to a92863d Compare September 25, 2024 02:43
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e8062471e6014786a644c3d8ec6c8ab4

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic RETRY_LIMIT in 9m 20s

@lewisdenny lewisdenny force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from a92863d to 01e76f3 Compare September 25, 2024 02:58
@lewisdenny lewisdenny force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from e766f26 to 5324920 Compare September 27, 2024 03:13
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aa38aaf786214ce0ad42c77be4219b65

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic FAILURE in 1h 25m 51s

@pablintino pablintino mentioned this pull request Sep 27, 2024
Merged
@lewisdenny lewisdenny force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from 5324920 to aa5a2b8 Compare October 1, 2024 01:09
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/16fc14fbd94c46e1951b399e415aaf75

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic FAILURE in 1h 25m 17s

@lewisdenny lewisdenny force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch 2 times, most recently from b3185d6 to 7de2ae5 Compare October 1, 2024 11:33
@lewisdenny lewisdenny marked this pull request as ready for review October 1, 2024 11:33
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a158d8bf9ee844838385577b4a0e7c60

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 22m 51s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 51s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 24s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 39m 11s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 44s
❌ cifmw-pod-pre-commit FAILURE in 8m 15s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 34s
✔️ build-push-container-cifmw-client SUCCESS in 30m 20s

@lewisdenny lewisdenny force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch 2 times, most recently from b82c420 to b734228 Compare October 1, 2024 22:51
@lewisdenny lewisdenny force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from b734228 to a3636e8 Compare October 2, 2024 03:48
@lewisdenny
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 3, 2024
@pablintino pablintino force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from a3636e8 to efa6988 Compare October 3, 2024 09:56
@pablintino pablintino force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from efa6988 to d8896ad Compare October 3, 2024 09:57
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/65140eef3f76450693ae9141af2cc22d

✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-deployment-crc-bootstrap-staging-ironic ERROR Unable to find playbook /var/lib/zuul/builds/bfeca99851c6400bb4d616d0a9ff78d1/untrusted/project_0/github.com/openstack-k8s-operators/ci-framework/ci/playbooks/edpm/fail.yml in 9s

@pablintino pablintino force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch 2 times, most recently from 2649ea6 to 24ddfe4 Compare October 3, 2024 10:00
@pablintino pablintino force-pushed the extracted-baremetal/ci-bootstrap-ironic-network branch from 24ddfe4 to a5ac0d2 Compare October 3, 2024 10:01
evallesp
evallesp reviewed Oct 3, 2024
View reviewed changes
Copy link

@evallesp evallesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. I'm unsure if there's something duplicated, and a couple of minor questions.

ci/playbooks/bootstrap-networking-mapper.yml
@@ -33,6 +33,7 @@
-e @scenarios/centos-9/base.yml
-e cifmw_networking_mapper_ifaces_info_path=/etc/ci/env/interfaces-info.yml
-e "@{{ ansible_user_dir }}/ci-framework-data/artifacts/parameters/zuul-params.yml"
-e cifmw_networking_mapper_ifaces_info_path=/etc/ci/env/interfaces-info.yml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(blocking) Unsure if necessary but I see this duplicated.

zuul.d/edpm_multinode.yaml
@@ -457,13 +399,13 @@
networks:
default: {}
internal-api:
trunk_parent: default
trunk-parent: default
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(non-blocking) question: Was this a typo?

zuul.d/nodeset.yaml
@@ -313,6 +313,23 @@
- name: ocps
nodes:
- crc
# todo: Remove. Temporal. Needed as the credentials used in ci-bootstrap jobs for IBM don't work
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(non-blocking) question: Do we expect to eventually roll back to IBM? I like the idea of the parent change so rolling that back it's just creating another child with the previous network configuration. Sounds like a good change IMHO.

frenzyfriday
frenzyfriday reviewed Oct 3, 2024
View reviewed changes
zuul.d/edpm_multinode.yaml
skip-nm-configuration: true
storage:
trunk_parent: default
trunk-parent: default
skip-nm-configuration: true
instances:
Copy link
Contributor

@frenzyfriday frenzyfriday Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt need the compute-0 anymore - it will get the compute info from the group-templates?

By compute-0 I mean:

            skip-nm-configuration: true
            networks:
              default:
                ip: "192.168.122.100"
              internal-api:
                ip: "172.17.0.100"
                trunk_parent: default
              storage:
                ip: "172.18.0.100"
                trunk_parent: default
              tenant:
                ip: "172.19.0.100"
                trunk_parent: default```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evallesp evallesp evallesp left review comments

@frenzyfriday frenzyfriday frenzyfriday left review comments

@lewisdenny lewisdenny lewisdenny approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablintino @lewisdenny @evallesp @frenzyfriday @openshift-merge-robot