Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0.0-proposed] Fix rbd pools trash purge scheduling #2378

Merged
merged 1 commit into from
Oct 15, 2024
Merged

[18.0.0-proposed] Fix rbd pools trash purge scheduling #2378

merged 1 commit into from
Oct 15, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2357

/assign katarimanojk

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 24, 2024
Merged
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft September 24, 2024 14:11
@pablintino
Copy link
Collaborator

/approve

fmount
fmount approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 14, 2024
@katarimanojk @fultonj
Fix rbd pools trash purge scheduling
6301aea 
This patch ensures to use the right conditions
and parameters while trash purge scheduling on
the rbd pools.

Jira: https://issues.redhat.com/browse/OSPRH-8504
@fultonj fultonj force-pushed the cherry-pick-2357-to-18.0.0-proposed branch from 60373f8 to 6301aea Compare October 14, 2024 11:37
@openshift-ci openshift-ci bot removed the lgtm label Oct 14, 2024
@fultonj fultonj marked this pull request as ready for review October 14, 2024 11:37
fultonj
fultonj approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fultonj, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cae51bf7bacb4feb88e6adee047bc836

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 13m 12s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 06s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 22m 41s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 39m 57s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 44s
✔️ cifmw-pod-pre-commit SUCCESS in 6m 58s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 30s

@lewisdenny
Copy link
Collaborator

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit ecfc89f into openstack-k8s-operators:18.0.0-proposed Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmount fmount fmount approved these changes

@fultonj fultonj fultonj approved these changes

@lewisdenny lewisdenny lewisdenny approved these changes

@bshewale bshewale Awaiting requested review from bshewale

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

Assignees

@fultonj fultonj

@fmount fmount

@katarimanojk katarimanojk

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @pablintino @lewisdenny @fultonj @fmount @katarimanojk