Make sure set_openstack_container is less depedent on instal_yamls #2389
Conversation
|
Thanks for the PR! ❤️ |
ciecierski
force-pushed
the
set_openstack_container_refactor
branch
from
f77c00f
to
28d3947
Compare
| @@ -105,14 +109,17 @@ | |||
| ansible.builtin.include_role: | |||
| name: 'install_yamls_makes' | |||
| tasks_from: 'make_wait' | |||
| when: | |||
| - operator_name != 'openstack' | |||
| - not cifmw_architecture_scenario is defined | |||
There was a problem hiding this comment.
The fact we need to check against the presence of cifmw_architecture_scenario in this role is a big red flag. But it's out of the scope of your change.
Cleanup set_openstack_container role by setting default values and omitting setting fact if install_yamls was not used during deployment. This is first atempt of reducing dependency of set_openstack_container role from install_yamls. The work that is left for later is for updating envs in operators other than openstack-operator. Task that waits for an operator update to complete will only work in install_yaml deployed enviroments and is skipped in architecture_scenario context.
ciecierski
force-pushed
the
set_openstack_container_refactor
branch
from
28d3947
to
dbc3488
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9535705faf7044239d0f4f2300ae2992 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 21s |
|
recheck |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit bff7cfb
into
openstack-k8s-operators:main
|
/cherry-pick 18.0.0-proposed |
|
@ciecierski: #2389 failed to apply on top of branch "18.0.0-proposed": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick 18.0.0-proposed |
|
@ciecierski: new pull request created: #2470 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Cleanup set_openstack_container role by setting default values and omitting
setting fact if install_yamls was not used during deployment.
This is first atempt of reducing dependency in set_openstack_container role
from install_yamls. The work that is left for later is for updating
ENVs in operators other than openstack-operator. Task that waits
for an operator(other than openstack-operator) update to complete will only work in install_yaml deployed environments and is skipped in architecture_scenario context.
Jira: https://issues.redhat.com/browse/OSPRH-10285