Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify RGW VIP is properly configured #2408

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Verify RGW VIP is properly configured #2408

merged 1 commit into from
Oct 2, 2024

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Sep 30, 2024 •
edited
Loading

No description provided.

@fmount fmount requested a review from fultonj September 30, 2024 09:12
@github-actions github-actions bot marked this pull request as draft September 30, 2024 09:12
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/76717cecb8e245dea8953fb48d8194a2

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 13m 33s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 14s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 22m 14s
❌ podified-multinode-hci-deployment-crc FAILURE in 2h 31m 39s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 18s
✔️ cifmw-pod-pre-commit SUCCESS in 6m 44s
✔️ build-push-container-cifmw-client SUCCESS in 31m 35s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 4m 58s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 13s

@fmount fmount force-pushed the PR#2273 branch 2 times, most recently from 0229c78 to 8a1d8b2 Compare September 30, 2024 14:09
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bb58bf67370c440aacd8b01fd67ea641

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 33m 18s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 21s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 18s
❌ podified-multinode-hci-deployment-crc FAILURE in 2h 29m 29s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 17s
✔️ cifmw-pod-pre-commit SUCCESS in 6m 45s
✔️ build-push-container-cifmw-client SUCCESS in 31m 02s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 14s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 10s

@fultonj
Copy link
Contributor

fultonj commented Sep 30, 2024 

2024-09-30 18:00:02.630 20 CRITICAL tempest [-] Unhandled error: config_tempest.services.base.ServiceError: Request on service 'share' with url 'https://manila-public-openstack.apps-crc.testing/v1/5bdeea74f87e49f5a3695883e78be47d/scheduler-stats/pools/detail' failed with code 401
2024-09-30 18:00:02.630 20 ERROR tempest Traceback (most recent call last):
2024-09-30 18:00:02.630 20 ERROR tempest   File "/usr/bin/discover-tempest-config", line 10, in <module>
2024-09-30 18:00:02.630 20 ERROR tempest     sys.exit(main())
2024-09-30 18:00:02.630 20 ERROR tempest   File "/usr/lib/python3.9/site-packages/config_tempest/main.py", line 617, in main
2024-09-30 18:00:02.630 20 ERROR tempest     config_tempest(
2024-09-30 18:00:02.630 20 ERROR tempest   File "/usr/lib/python3.9/site-packages/config_tempest/main.py", line 559, in config_tempest
2024-09-30 18:00:02.630 20 ERROR tempest     services = Services(clients, conf, credentials)
2024-09-30 18:00:02.630 20 ERROR tempest   File "/usr/lib/python3.9/site-packages/config_tempest/services/services.py", line 42, in __init__
2024-09-30 18:00:02.630 20 ERROR tempest     self.discover()
2024-09-30 18:00:02.630 20 ERROR tempest   File "/usr/lib/python3.9/site-packages/config_tempest/services/services.py", line 122, in discover
2024-09-30 18:00:02.630 20 ERROR tempest     service.set_default_tempest_options(self._conf)
2024-09-30 18:00:02.630 20 ERROR tempest   File "/usr/lib/python3.9/site-packages/config_tempest/services/share.py", line 48, in set_default_tempest_options
2024-09-30 18:00:02.630 20 ERROR tempest     pools = self.get_share_pools(detail=True)['pools']
2024-09-30 18:00:02.630 20 ERROR tempest   File "/usr/lib/python3.9/site-packages/config_tempest/services/share.py", line 37, in get_share_pools
2024-09-30 18:00:02.630 20 ERROR tempest     body = self.do_get(url)
2024-09-30 18:00:02.630 20 ERROR tempest   File "/usr/lib/python3.9/site-packages/config_tempest/services/base.py", line 80, in do_get
2024-09-30 18:00:02.630 20 ERROR tempest     raise ServiceError("Request on service '%s' with url '%s' failed"
2024-09-30 18:00:02.630 20 ERROR tempest config_tempest.services.base.ServiceError: Request on service 'share' with url 'https://manila-public-openstack.apps-crc.testing/v1/5bdeea74f87e49f5a3695883e78be47d/scheduler-stats/pools/detail' failed with code 401
2024-09-30 18:00:02.630 20 ERROR tempest �[00m

https://logserver.rdoproject.org/08/2408/8a1d8b2df05c0c4ec97d7736497dcaf04e0775e4/github-check/podified-multinode-hci-deployment-crc/2950e0b/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/tempest-tests-bm4mn/logs/tempest-tests-tests-runner.log

@fmount fmount force-pushed the PR#2273 branch 7 times, most recently from 0af7520 to caf5dfc Compare October 1, 2024 06:57
@fmount fmount mentioned this pull request Oct 1, 2024
Open
@fmount fmount force-pushed the PR#2273 branch 2 times, most recently from cd3b06d to e84c11b Compare October 1, 2024 10:52
@fmount
Copy link
Contributor Author

fmount commented Oct 1, 2024

Endpoints look good, and tempest worked [1]

[1] https://logserver.rdoproject.org/08/2408/e84c11b87bc451a4b35e790d6efa9507d3f4775d/github-check/podified-multinode-hci-deployment-crc/4b1dfa4/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/ctlplane/endpoints

@fmount fmount force-pushed the PR#2273 branch 4 times, most recently from 81363dd to d422a86 Compare October 1, 2024 14:52
@fmount fmount changed the title DNM - Test CI when configuring Manila with an NFS network Verify RGW VIP is properly configured Oct 1, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d10aa796fb6548d8a1675de2f6e0897b

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 16m 18s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 25s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 27s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 39m 13s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 43s
❌ cifmw-pod-pre-commit FAILURE in 7m 18s
✔️ build-push-container-cifmw-client SUCCESS in 31m 04s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 16s

@fmount fmount force-pushed the PR#2273 branch 2 times, most recently from 6d06445 to 8686840 Compare October 1, 2024 19:25
@fmount fmount marked this pull request as ready for review October 1, 2024 19:25
@fultonj
Copy link
Contributor

fultonj commented Oct 2, 2024 •
edited
Loading

Want to rebase on #2418 ?

@fmount
Copy link
Contributor Author

fmount commented Oct 2, 2024

rebased

@fultonj @fmount
Verify RGW VIP is properly configured in keystone
298fad1 
We had an issue related to the rgw_vip configuration. This patch removes
the cidr usage from the facts and passes it to the rgw ingress template.
In addition, ipaddr filter is used to properly get the ipaddress and
fail if malformed (or is just not what we expect).
@pablintino
Copy link
Collaborator

/trigger github-experimental

fultonj
fultonj reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +2 to merge this.

Let's just make sure the github-experimental check passes first.

@fmount fmount requested a review from pablintino October 2, 2024 13:34
@pablintino
Copy link
Collaborator

The testproject passed
/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 2, 2024
@pablintino
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ed82055 into openstack-k8s-operators:main Oct 2, 2024
4 checks passed
@fultonj
Copy link
Contributor

fultonj commented Oct 2, 2024

Should we cherry pick this to the next release?

@fmount
Copy link
Contributor Author

fmount commented Oct 3, 2024

Should we cherry pick this to the next release?

Makes sense to me.

@fmount
Copy link
Contributor Author

fmount commented Oct 3, 2024

/cherrypick 18.0.0-proposed

@openshift-cherrypick-robot
Copy link

@fmount: new pull request created: #2421

In response to this:

/cherrypick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fultonj fultonj fultonj left review comments

@pablintino pablintino Awaiting requested review from pablintino

Assignees

@pablintino pablintino

Labels
approved github-experimental lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmount @fultonj @pablintino @openshift-cherrypick-robot