Move test-operator CR name variables from vars to defaults folder #2411
Conversation
Currently, the names of the resources created by the test-operator role were defined by variables in the vars folder of test-operator role. We want to move those vars to defaults folder to enable their easier customization. The main reason why this name customization might be useful is to be able to run tempest multiple times without doing cleanup for every tempest run.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the PR! ❤️ |
There was a problem hiding this comment.
Overall looks good to me 👍
If it is about enabling multiple runs of the test-operator role within a single job without the need of running a cleanup then can you please add the renaming for the test-operator-logs pod (the same way as here [1])?
Also, the README.md section where cifmw_test_operator_*_config is defined needs to be updated (e.g., Tempest.Metadata.Name).
[1] here
|
Closing in favor of #2412 |
Currently the names of the resources created with test-operator role were defined by variables in the vars folder of test-operator role. We want to move those vars to defaults folder to enable their easier customization. The main reason why this name customization might be useful is to be able to run tempest multiple times without doing cleanup of CRs for every tempest run.