Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adoption fernet session token test #546

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix adoption fernet session token test #546

wants to merge 1 commit into from
+21 −10

Conversation

afaranha
Copy link
Contributor

@afaranha afaranha commented Jul 29, 2024 •
edited by xek
Loading

@afaranha afaranha marked this pull request as draft July 29, 2024 13:05
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@afaranha

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@afaranha

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@xek xek changed the title Fix adoption token test Fix adoption fernet session token test Oct 22, 2024
@xek xek marked this pull request as ready for review October 22, 2024 07:57
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/731bbc508fc04d6f850d5d40da04f9e4

❌ adoption-standalone-to-crc-ceph NODE_FAILURE Node request 100-0007633723 failed in 0s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 1h 51m 04s

@afaranha
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9fa64a42b79e493186fa3b2970afc916

❌ adoption-standalone-to-crc-ceph FAILURE in 50m 05s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 1h 56m 48s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/90f29e7a01b24fe4a5514965b7ff005c

❌ adoption-standalone-to-crc-ceph FAILURE in 1h 59m 12s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 1h 56m 09s

@xek xek force-pushed the fix_fernet_token_test branch 2 times, most recently from 2a7dc4a to 4561eb5 Compare November 12, 2024 08:24
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3a30efe7914e4ba7bcdf044c0de2b566

✔️ adoption-standalone-to-crc-ceph SUCCESS in 3h 16m 31s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 2h 29m 50s

@xek
Copy link
Contributor

xek commented Nov 12, 2024

recheck

@xek xek requested review from fmount and jistr November 13, 2024 08:05
@xek xek force-pushed the fix_fernet_token_test branch 2 times, most recently from c4b0188 to 56b3340 Compare November 18, 2024 13:42
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/309d186c1c154faba3424a59e93f20f7

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 3h 19m 03s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 2h 30m 01s

@xek
Copy link
Contributor

xek commented Nov 19, 2024

recheck

@xek
Fail when token is invalid
7ffb278 
Make sure the openstack command is using the fernet
token to authenticate.
fmount
fmount approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xek xek xek left review comments

@fmount fmount fmount approved these changes

@jistr jistr jistr approved these changes

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afaranha @xek @jistr @fmount