Fix Swift migration tests and remove fixed IP #710
Conversation
| @@ -25,7 +31,9 @@ | |||
| {{ oc_header }} | |||
| oc debug --keep-labels=true job/swift-ring-rebalance -- /bin/sh -c ' | |||
| swift-ring-tool get | |||
| swift-ring-tool drain 172.20.0.100 | |||
| for node in {{ swift_node_list_result.stdout }}; do | |||
There was a problem hiding this comment.
The content of swift_node_list_result.stdout is a newlines separate list, which breaks the shell interpretation as the items behind the first one creates new lines, apparently. Or at least it looks like from the logs:
fatal: [localhost]: FAILED! => {"changed": true, "cmd": "\noc debug --keep-labels=true job/swift-ring-rebalance -- /bin/sh -c '\nswift-ring-tool get\nfor node in 172.20.0.103\n172.20.0.104\n172.20.0.105; do\n swift-ring-tool drain ${node}\ndone\nswift-ring-tool forced_rebalance\nswift-ring-tool push'\n", "delta": "0:00:02.250242", "end": "2024-11-08 08:26:10.942126", "msg": "non-zero return code", "rc": 1, "start": "2024-11-08 08:26:08.691884", "stderr": "Starting pod/swift-ring-rebalance-debug-kwp8d, command was: /usr/local/bin/swift-ring-tool all\n\nRemoving debug pod ...\nerror: non-zero exit code from debug container", "stderr_lines": ["Starting pod/swift-ring-rebalance-debug-kwp8d, command was: /usr/local/bin/swift-ring-tool all", "", "Removing debug pod ...", "error: non-zero exit code from debug container"], "stdout": "Total bytes read: 122880 (120KiB, 33MiB/s)\n/bin/sh: -c: line 4: syntax error near unexpected token 172.20.0.104'\n/bin/sh: -c: line 4: 172.20.0.104'", "stdout_lines": ["Total bytes read: 122880 (120KiB, 33MiB/s)", "/bin/sh: -c: line 4: syntax error near unexpected token 172.20.0.104'", "/bin/sh: -c: line 4: 172.20.0.104'"]}
| @@ -100,6 +108,8 @@ | |||
| CONTROLLER1_SSH="{{ controller1_ssh }}" | |||
| oc debug --keep-labels=true job/swift-ring-rebalance -- /bin/sh -c ' | |||
| swift-ring-tool get | |||
| swift-ring-tool remove 172.20.0.100 | |||
| for node in {{ swift_node_list_result.stdout }}; do | |||
There was a problem hiding this comment.
this is probably affected by the same issue as above
The fixed IP is valid for CRC/standalone testing, however it is most likely not for any other deployments. Instead of using a fixed IP getting the IPs of the former storage nodes before adding PVCs will cover many more cases.
cschwede
force-pushed
the
fix-swift-migration-remove-fixed-ip
branch
from
4cd07df
to
be4031a
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/76a557c7564d4d7eb7800056ece7d737 ✔️ noop SUCCESS in 0s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8c3b591c0787459fa3248c38cb125211 ✔️ noop SUCCESS in 0s |
The fixed IP is valid for CRC/standalone testing, however it is most likely not for any other deployments. Instead of using a fixed IP getting the IPs of the former storage nodes before adding PVCs will cover many more cases.