Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the idle timeout #314

Closed
wants to merge 1 commit into from
Closed

Reduce the idle timeout #314

wants to merge 1 commit into from

Conversation

fao89
Copy link
Contributor

@fao89 fao89 commented Sep 7, 2023

When the job fails, it waits 10 minutes to kill the job. Reducing it to 5 minutes

@fao89
Reduce the idle timeout
a1b3501 
When the job fails, it waits 10 minutes to kill the job.
Reducing it to 5 minutes

Signed-off-by: Fabricio Aguiar <[email protected]>
@openshift-ci openshift-ci bot requested review from kajinamit and slagle September 7, 2023 14:54
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 7, 2023
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5edfd0c098c44dd091d0692c0ea936fb

✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 51s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 14s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 26s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 01s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 05s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 53s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 19m 39s
❌ edpm-ansible-crc-podified-edpm-baremetal FAILURE in 1h 02m 15s

@fao89
Copy link
Contributor Author

fao89 commented Sep 8, 2023

recheck

jpodivin
jpodivin reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@jpodivin jpodivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to adjust the variable in the cases when it idles for too long?

@fao89
Copy link
Contributor Author

fao89 commented Sep 11, 2023

I think 10 minutes is too long, do we have any task that might idle for that long?
In any case, how can we know beforehand a task might idle for 5+ minutes?

@fao89 fao89 mentioned this pull request Sep 11, 2023
Merged
rabi
rabi reviewed Sep 11, 2023
View reviewed changes
openstack_ansibleee/settings
@@ -1,6 +1,6 @@
# If no output is detected from ansible in this number of seconds the execution will
# be terminated.
idle_timeout: ${RUNNER_IDLE_TIMEOUT:-600}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the ansible runner default https://ansible.readthedocs.io/projects/runner/en/stable/intro/#env-settings-settings-for-runner-itself. Not sure if we should reduce it.

We probably could find the better way to know that the job has failed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to find something in the ansible-runner to understand why it hangs when it fails, but I didn't find anything

@fao89
Copy link
Contributor Author

fao89 commented Sep 11, 2023

I'll close as it is not the real issue, the real issue is to avoid ansible hanging when it fails

@fao89 fao89 closed this Sep 11, 2023
@fao89
Copy link
Contributor Author

fao89 commented Dec 13, 2023

I'll close as it is not the real issue, the real issue is to avoid ansible hanging when it fails

this was the root cause: ansible/ansible-runner#1327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabi rabi rabi left review comments

@jpodivin jpodivin jpodivin left review comments

@kajinamit kajinamit Awaiting requested review from kajinamit

@slagle slagle Awaiting requested review from slagle

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fao89 @rabi @jpodivin