Stylistic adjustments for modules, plugins and filters

[jpodivin]

We have accumulated quite a bit of idiosyncracies in our python code. This doesn't resolve all of them by any means, but it does take care of some of the most egregious ones. Dead code, useless imports, duplication and typos are all included.

None of these changes should alter the way our code works. I've tried to avoid veering into full on refactor with this. That being said there is one minor change of osp.edpm.haskey filter API. However the filter in question is only used by one role, so it shouldn't have any adverse effects.

Normally I would squash this. But since most of these are rather disjoint issues, I can't help but feel that it would make a mess of blame for whoever will follow. So I'm keeping the commits separate, unless people insist on squashing.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jpodivin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2ff7d5d455b84281be59e7d1fa33f7fb

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 40m 25s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 48m 01s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 8m 44s
✔️ edpm-ansible-molecule-edpm_bootstrap SUCCESS in 5m 57s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 4m 51s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 24s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 8m 25s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 7m 59s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 8m 35s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 6m 07s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 20s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 6m 39s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 24s
✔️ edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 3m 49s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 3h 12m 09s

[jpodivin]

recheck

The connection to the server oauth-openshift.apps-crc.testing was refused - did you specify the right host or port?
Can not login to the CRC cluster. Sleeping...
Checking login to the cluster 18...
WARNING: Using insecure TLS client config. Setting this option is not supported!

[rebtoor]

@jpodivin PR is more than fine for me but i'm testing it downstream just to be extra sure about its impact. As long as that test will pass, i'll give my lgtm.