Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ServiceNetwork optional in IPSetReservration #309

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Nov 18, 2024

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rabi, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6453503938b843d2841542ce418c63f5

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 43s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 29s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 20m 40s

@stuggi
Copy link
Contributor

stuggi commented Nov 18, 2024

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit d52a058 into openstack-k8s-operators:main Nov 18, 2024
7 checks passed
@stuggi
Copy link
Contributor

stuggi commented Nov 18, 2024

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@stuggi: new pull request created: #310

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants