Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 support for network attachements #687

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Jan 10, 2024

When NETWORK_ISOLATION_IPV6 (default: false) is true, configure the NAD for IPv6.
Likewize NETWORK_ISOLATION_IPV4 (default: true) controls if IPv4 is configured.

Enabling both IPv6 and IPv4 should work for dual stack.

@openshift-ci openshift-ci bot requested review from abays and fultonj January 10, 2024 15:21
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hjensas
Once this PR has been reviewed and has the lgtm label, please assign raukadah for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ba67db6b24a04cdbb8d03bbd3eff15f6

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 34s
install-yamls-crc-podified-edpm-baremetal RETRY_LIMIT in 11m 45s
podified-multinode-edpm-deployment-crc FAILURE in 1h 04m 23s
content-provider-data-plane-adoption-OSP-17-to-extracted-crc RETRY_LIMIT in 1h 11m 16s

@hjensas
Copy link
Contributor Author

hjensas commented Jan 11, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/93c90957973b4c8aae9b999b90b53771

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 26m 12s
install-yamls-crc-podified-edpm-baremetal FAILURE in 1h 04m 36s
podified-multinode-edpm-deployment-crc FAILURE in 1h 02m 30s
content-provider-data-plane-adoption-OSP-17-to-extracted-crc RETRY_LIMIT in 1h 08m 58s

@hjensas
Copy link
Contributor Author

hjensas commented Jan 13, 2024

It looks like wherabouts is quite dated, and does not contain the ipRanges support addded in: k8snetworkplumbingwg/whereabouts@950ab71

 failed (add): [openstack/glance-db-sync-ppn98/fa629d91-9963-46a2-b8f6-3c8d8260bc14:storage]: 
error adding container to network "storage": invalid CIDR : invalid CIDR address:

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/68bcf6f35ff740dc80ce39567717da16

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 18m 03s
install-yamls-crc-podified-edpm-baremetal RETRY_LIMIT in 3s
podified-multinode-edpm-deployment-crc FAILURE in 1h 02m 50s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/041f650764044b5ea362ca706d4d2819

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 20m 54s
install-yamls-crc-podified-edpm-baremetal FAILURE in 1h 05m 15s
podified-multinode-edpm-deployment-crc FAILURE in 1h 02m 12s

When NETWORK_ISOLATION_IPV6 (default: false) is true, configure the NAD for IPv6.
Likewize NETWORK_ISOLATION_IPV4 (default: true) controls if IPv4 is configured.

Enabling both IPv6 and IPv4 should work for dual stack.

Signed-off-by: Harald Jensås <[email protected]>
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7c0aa41349e1407887b3c1f6415a2ffd

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 21m 35s
podified-multinode-edpm-deployment-crc FAILURE in 1h 04m 44s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant