-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds bits to set domain and enable tlse for adoption multinode ci jobs #897
Adds bits to set domain and enable tlse for adoption multinode ci jobs #897
Conversation
Skipping CI for Draft Pull Request. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, marios The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
45eee21
to
1bdbfe5
Compare
9fbd7ca
to
42664c5
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/49ef7cfc4ef84f97a095fd93c282a503 ✔️ openstack-k8s-operators-content-provider SUCCESS in 5h 28m 35s |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/37890572e87e40ea9d1d821019712d78 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 05m 27s |
16475a6
to
4610318
Compare
setting ready for review. With the latest changes we got a green run at https://softwarefactory-project.io/zuul/t/rdoproject.org/build/61b17dc1e88f4461a54898d451e42d46 (the subsequent run failed but i think it was a transient issue/re-running) |
/lgtm just left a couple of comments about documenting assumptions and one question |
As part of [1] this aims to enable tls for the adoption multinode ci. We have to move some of the overcloud config to j2 templates so we can include the right values for cloud_domain (dns domain). It also adds the external network for the tripleo controllers as without it the tls deployment code fails. Finally this includes the startup of the freeipa server as a container on the undercloud. Also see related patch at [2]. [1] https://issues.redhat.com/browse/OSPRH-8973 [2] https://review.rdoproject.org/r/c/rdo-jobs/+/54102
holding for green run on the ceph/non tls job |
|
/lgtm |
1adbc5b
into
openstack-k8s-operators:main
This adds enable_tls for the multinode-no-ceph job as part of [1]. It passes the enable-tls and cloud domain vars through to the tripleo deployment and adoption tests execution. Includes needed workarounds for TLS such as creating missing /etc/pki/CA directory, updating resolv.conf and creating needed IP route for overcloud nodes. Depends-On: openstack-k8s-operators/install_yamls#897 [1] https://issues.redhat.com/browse/OSPRH-8973 Change-Id: I440f123df34b2ba0a118ecaceb90fb44bad63ae5
As part of [1] this aims to enable tls for the adoption multinode ci. We
have to move some of the overcloud config to j2 templates so we can
include the right values for cloud_domain (dns domain). It also adds
the external network for the tripleo controllers as without it the tls
deployment code fails. Finally this includes the startup of the freeipa
server as a container on the undercloud. Also see related patch at [2].
[1] https://issues.redhat.com/browse/OSPRH-8973
[2] https://review.rdoproject.org/r/c/rdo-jobs/+/54102