Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds bits to set domain and enable tlse for adoption multinode ci jobs #897

Merged

Conversation

marios
Copy link
Contributor

@marios marios commented Aug 16, 2024

As part of [1] this aims to enable tls for the adoption multinode ci. We
have to move some of the overcloud config to j2 templates so we can
include the right values for cloud_domain (dns domain). It also adds
the external network for the tripleo controllers as without it the tls
deployment code fails. Finally this includes the startup of the freeipa
server as a container on the undercloud. Also see related patch at [2].

[1] https://issues.redhat.com/browse/OSPRH-8973
[2] https://review.rdoproject.org/r/c/rdo-jobs/+/54102

Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fao89
Copy link
Contributor

fao89 commented Sep 9, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, marios

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marios marios force-pushed the OSPRH-8973 branch 3 times, most recently from 9fbd7ca to 42664c5 Compare September 25, 2024 07:28
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/49ef7cfc4ef84f97a095fd93c282a503

✔️ openstack-k8s-operators-content-provider SUCCESS in 5h 28m 35s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 24m 12s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 13s
adoption-standalone-to-crc-ceph-provider TIMED_OUT in 4h 17m 00s
adoption-standalone-to-crc-no-ceph-provider TIMED_OUT in 4h 16m 09s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/37890572e87e40ea9d1d821019712d78

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 05m 27s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 25m 30s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 12s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 36m 39s
adoption-standalone-to-crc-no-ceph-provider FAILURE in 2h 41m 17s

@marios marios force-pushed the OSPRH-8973 branch 4 times, most recently from 16475a6 to 4610318 Compare October 7, 2024 09:18
@marios marios requested review from xek and cescgina October 7, 2024 09:19
@marios marios marked this pull request as ready for review October 7, 2024 09:19
@openshift-ci openshift-ci bot requested review from abays and dprince October 7, 2024 09:19
@marios
Copy link
Contributor Author

marios commented Oct 7, 2024

setting ready for review. With the latest changes we got a green run at https://softwarefactory-project.io/zuul/t/rdoproject.org/build/61b17dc1e88f4461a54898d451e42d46

(the subsequent run failed but i think it was a transient issue/re-running)

@cescgina
Copy link
Contributor

cescgina commented Oct 7, 2024

/lgtm just left a couple of comments about documenting assumptions and one question

As part of [1] this aims to enable tls for the adoption multinode ci. We
have to move some of the overcloud config to j2 templates so we can
include the right values for cloud_domain (dns domain). It also adds
the external network for the tripleo controllers as without it the tls
deployment code fails. Finally this includes the startup of the freeipa
server as a container on the undercloud. Also see related patch at [2].

[1] https://issues.redhat.com/browse/OSPRH-8973
[2] https://review.rdoproject.org/r/c/rdo-jobs/+/54102
@marios
Copy link
Contributor Author

marios commented Oct 9, 2024

holding for green run on the ceph/non tls job

@marios marios marked this pull request as ready for review October 9, 2024 14:28
@marios
Copy link
Contributor Author

marios commented Oct 9, 2024

@cescgina
Copy link
Contributor

cescgina commented Oct 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1adbc5b into openstack-k8s-operators:main Oct 9, 2024
4 of 5 checks passed
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Oct 11, 2024
This adds enable_tls for the multinode-no-ceph job as part of [1]. It
passes the enable-tls and cloud domain vars through to the tripleo
deployment and adoption tests execution. Includes needed workarounds
for TLS such as creating missing /etc/pki/CA directory, updating
resolv.conf and creating needed IP route for overcloud nodes.

Depends-On: openstack-k8s-operators/install_yamls#897

[1] https://issues.redhat.com/browse/OSPRH-8973

Change-Id: I440f123df34b2ba0a118ecaceb90fb44bad63ae5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants