Re-init conditions each reconcile #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch follows the same pattern applied to the other operators, where we re-init the condition at each reconcile loop. Conditions are re-evaluated and updated, keeping the LastTransitionTime for those that haven't changed (it avoids the transition from True to Unknown to True again). In addition, the "observedGeneration" field is introduced, and it is used by the openstack-operator to check the IsReady() function for a particular CR in case a minor update is triggered. All the conditions are evaluated during the main Reconcile loop ( or the reconcileNormal function in some circumstances), hence the main ReadyCondition is updated within the same flow. The defer function still updates the Resource and Mirror the condition to the top-level CR. Signed-off-by: Francesco Pantano <[email protected]>
steveb
approved these changes
Apr 3, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, steveb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f5716b4
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch follows the same pattern applied to the other operators, where we re-init the
conditionsat each reconcile loop.Conditionsare re-evaluated and updated, keeping theLastTransitionTimefor those that haven't changed (it avoids the transition fromTruetoUnknowntoTrueagain).In addition, the
observedGenerationfield is introduced, and it is used by theopenstack-operatorto check theIsReady()function for a particularCRin case a minor update is triggered. All the conditions are evaluated during the mainReconcileloop ( or thereconcileNormalfunction in some circumstances), hence the mainReadyConditionis updated within the same flow. The defer function still updates theResourceandMirrorthe condition to the top-levelCR.Jira: OSPRH-5919
Jira: OSPRH-5698