Move some validation from kubebuilder annotation to webhook #418
Conversation
|
@hjensas please have a look and let me know what you think about doing this change. basically with this change we can deploy an osctlplane with not have to specify anything for the services which are disabled per default |
stuggi
force-pushed
the
osctlplane_integration_fix
branch
from
dc53a06
to
bbdd13c
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/c5eb4ab8f666411594206d1bffcdb112 ❌ openstack-k8s-operators-content-provider FAILURE in 10m 44s |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/93a15dda988a4a7ca14ce1bbafa1f045 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 06m 58s |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4ab6e1a721434ea399ac8d109f51efd6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 08m 18s |
I'm ok with this. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, hjensas, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
the tempest vif test errors looks not to be related to this pr. we also see them in #420 |
|
Tempest seems to be failing consistently, with the same number of failures. For example [1]. |
Here's the one that ran previous to this job: https://logserver.rdoproject.org/18/418/bbdd13ce46e4ee96a36e3e9239eabd34bc16a4a5/github-check/podified-multinode-ironic-deployment/21d92f7/controller/ci-framework-data/tests/tempest/tempest/tempest_results.xml |
|
Also, I did not mean to imply that the Tempest failures are related to this PR :) |
|
yes, it seems to be happening in current PRs |
|
We need to disable those test - openstack-k8s-operators/ci-framework#1541. We just disabled them downstream as well, there needs to be some fixing in upstream ironic for those VIFs tests to work. |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/f977d80635e24bdabbe149aa72a684c9 ❌ openstack-k8s-operators-content-provider FAILURE in 9m 44s |
Right now applying a OpenStackControlPlane CR without any ironic section fails with: ~~~ $ oc apply -n openstack -f ... The OpenStackControlPlane "openstack-galera-network-isolation-3replicas" is invalid: * spec.ironic.template.rpcTransport: Unsupported value: "": supported values: "oslo", "json-rpc" * spec.ironic.template.ironicConductors: Invalid value: "null": spec.ironic.template.ironicConductors in body must be of type array: "null" ~~~ To allow the OpenstackControlPlane to be deployed without specifying any ironic there is the need to change the validation/defaulting of the RPCTransport and IronicConductors. * RPCTransport The enum check is moved to the validations webhook for create and update, default set in the defaulting webhook. * IronicConductors IronicConductors not longer a required parameter from kubebuilder pov, but in the validations webhook checked that length of the array is > 0
stuggi
force-pushed
the
osctlplane_integration_fix
branch
from
bbdd13c
to
9ef78a3
Compare
|
New changes are detected. LGTM label has been removed. |
|
rebased |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/5b760f68bc3745aeb60b3e950b0588f0 ❌ openstack-k8s-operators-content-provider FAILURE in 10m 01s |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/a972e7a57a964da89e03697862e3874f ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 12m 17s |
|
recheck apparent race condition in port deletion triggered the prior run to fail |
openshift-merge-bot
bot
merged commit 290992b
into
openstack-k8s-operators:main
Right now applying a OpenStackControlPlane CR without any ironic section fails with:
To allow the OpenstackControlPlane to be deployed without specifying any ironic there is the need to change the validation/defaulting of the RPCTransport and IronicConductors.
RPCTransport The enum check is moved to the validations webhook for create and update, default set in the defaulting webhook.
IronicConductors IronicConductors not longer a required parameter from kubebuilder pov, but in the validations webhook checked that length of the array is > 0