Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PodManagementPolicy: appsv1.ParallelPodManagement for statefulset #436

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Jun 7, 2024

With the default PodManagementPolicy: OrderedReadyPodManagement the statefulset controller will only progress pods when the previous/current pod is ready or terminated.

When service configuration changes while the pod is starting and the new configuration requires e.g. additional volume mounts the initial pod will never reach ready and therefore an update won't happen.

With ParallelPodManagement the statefulset controller will not wait for pods to be ready or complete termination.

With the default PodManagementPolicy: OrderedReadyPodManagement
the statefulset controller will only progress pods when the
previous/current pod is ready or terminated.

When service configuration changes while the pod is starting
and the new configuration requires e.g. additional volume mounts
the initial pod will never reach ready and therefore an update
won't happen.

With ParallelPodManagement the statefulset controller will
not wait for pods to be ready or complete termination.

Signed-off-by: Francesco Pantano <[email protected]>
@fmount fmount requested review from stuggi and bshephar June 7, 2024 06:31
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, hjensas, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hjensas
Copy link
Contributor

hjensas commented Jun 7, 2024

/test ironic-operator-build-deploy-kuttl

@openshift-merge-bot openshift-merge-bot bot merged commit 2f2e4f3 into openstack-k8s-operators:main Jun 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants