Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ramdisk-logs sidecar #466

Closed
wants to merge 2 commits into from

Conversation

steveb
Copy link
Collaborator

@steveb steveb commented Aug 26, 2024

This implements the runlogwatch.sh approach of metal3[1] to write any deployment logs to the console, making them accessable to the end user via the same mechanism as other openstack service logs.

Jira: OSPRH-1947

[1] https://github.com/metal3-io/ironic-image/blob/main/scripts/runlogwatch.sh

Copy link
Contributor

openshift-ci bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@steveb
Copy link
Collaborator Author

steveb commented Aug 26, 2024

Once openstack-k8s-operators/tcib#205 lands I can propose this switch to using inotifywait, like I have proposed for metal3 metal3-io/ironic-image#540

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0a821bc013e540b5a5774d48157fa03c

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 17m 57s
podified-multinode-ironic-deployment FAILURE in 1h 01m 01s

This implements the runlogwatch.sh approach of metal3[1] to write any
deployment logs to the console, making them accessable to the end user
via the same mechanism as other openstack service logs.

Jira: OSPRH-1947

[1] https://github.com/metal3-io/ironic-image/blob/main/scripts/runlogwatch.sh
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e3eb3fb73b2f4380bd2ffdfa911dd673

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 19m 40s
podified-multinode-ironic-deployment FAILURE in 1h 01m 35s

Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

@steveb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ironic-operator-build-deploy-kuttl c017f09 link true /test ironic-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9e8657d4c2444f4682a2a7c5e4090a4f

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 10h 56m 05s
podified-multinode-ironic-deployment FAILURE in 1h 03m 16s

@steveb
Copy link
Collaborator Author

steveb commented Sep 11, 2024

I'm going to do another PR from a different branch

@steveb steveb closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant