Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up usage of /var/log/ironic #472

Merged

Conversation

steveb
Copy link
Collaborator

@steveb steveb commented Sep 16, 2024

  • Add missing log mount to ironic-api
  • Fix names of config-data volume mounts
  • Align all httpd logging directives
  • Don't set /var/log/ironic permissions in dbsync container
  • Don't set /var/log/ironic permissions in conductor pod

The first item fixes an actual but where ironic-api logging was not written to stdout. The rest of the commits are cleanups

ironic-api-log is not currently logging anything because /var/log/ironic
is not mounted into the ironic-api container. This change fixes that.
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7e182e3e867c4033a7430b69d6a076b8

✔️ noop SUCCESS in 0s
openstack-k8s-operators-content-provider FAILURE in 9m 42s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

- move all logging directives out of <VirtualHost>
- remove any file based logging
- ensure all logging is to stdout consistent across all httpd configs
This container doesn't log to /var/log/ironic, nor is a volume mounted
at that mountpoint.
All containers in this pod log to stdout, and no volume used
/var/log/ironic as a mountpoint.
These clashed with the existing config-data-merged mount which is
included in all containers.
Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hjensas, steveb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 13e2efa into openstack-k8s-operators:main Sep 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants