Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to golang 1.21 and k8s to 1.29 #473

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Bump to golang 1.21 and k8s to 1.29 #473

merged 1 commit into from
Sep 26, 2024
+141 −150

Conversation

steveb
Copy link
Collaborator

@steveb steveb commented Sep 16, 2024 •
edited by openshift-ci bot
Loading

@steveb steveb requested a review from stuggi September 16, 2024 23:05
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aa847e90bd134219b68ee546b4309ef0

✔️ noop SUCCESS in 0s
❌ openstack-k8s-operators-content-provider FAILURE in 8m 58s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@steveb steveb changed the title Bump to golang 1.21 Bump to golang 1.21 and k8s to 1.29 Sep 16, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/894cfe7013934c29aba93f91904e33e7

✔️ noop SUCCESS in 0s
❌ openstack-k8s-operators-content-provider FAILURE in 8m 50s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/18bc7f574de749ce8f813e9d4e161c6d

✔️ noop SUCCESS in 0s
❌ openstack-k8s-operators-content-provider FAILURE in 9m 00s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cf368056b31540cc958c5d87fc75f1e1

✔️ noop SUCCESS in 0s
❌ openstack-k8s-operators-content-provider FAILURE in 8m 51s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b6dc4dab0c5a490dbeb4171adeca6140

✔️ noop SUCCESS in 0s
❌ openstack-k8s-operators-content-provider FAILURE in 8m 53s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@steveb
Copy link
Collaborator Author

steveb commented Sep 17, 2024

/retest

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ba99b0a3111a46b68a96b32a8574bb12

✔️ noop SUCCESS in 0s
❌ openstack-k8s-operators-content-provider FAILURE in 11m 46s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/49c3d165de3e43a587b91ae18de5dc63

✔️ noop SUCCESS in 0s
❌ openstack-k8s-operators-content-provider FAILURE in 10m 43s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c1974c1b49ac4d588bdf21e00ccd6735

✔️ noop SUCCESS in 0s
❌ openstack-k8s-operators-content-provider FAILURE in 11m 47s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@stuggi
Copy link
Contributor

stuggi commented Sep 25, 2024

/retest

@stuggi
Copy link
Contributor

stuggi commented Sep 25, 2024

recheck

@stuggi
Copy link
Contributor

stuggi commented Sep 25, 2024

you'd need to run make tidy to fix the pre-commit issue

@stuggi
Copy link
Contributor

stuggi commented Sep 26, 2024

fyi, I have pushed to fix the pre-commit issue to get this PR in . its the remaining operator to get to 1.21

stuggi
stuggi approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveb, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8ec6f97 into openstack-k8s-operators:main Sep 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuggi stuggi stuggi approved these changes

@hjensas hjensas Awaiting requested review from hjensas

@juliakreger juliakreger Awaiting requested review from juliakreger

Assignees

@stuggi stuggi

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steveb @stuggi