[DNM] remove extra lines from confs #855
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: auniyal61 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/59bc287336524238b601cc4ff4ac8dd4 ✔️ openstack-meta-content-provider SUCCESS in 2h 18m 43s |
|
@auniyal61 I guess Depends-On is not enough here. You need to add the following line in the go.mod file in this patch to point to the in progress lib-common change. You can ignore the pre-commit check error that will appear after this. We cannot land a patch with a replace line pointing to a fork. But we could use this replace line to test the lib-common change. |
|
@gibizer , thanks updated |
|
/retest |
go.mod
Outdated
| @@ -88,3 +88,4 @@ replace github.com/openstack-k8s-operators/nova-operator/api => ./api | |||
| // mschuppert: map to latest commit from release-4.13 tag | |||
| // must consistent within modules and service operators | |||
| replace github.com/openshift/api => github.com/openshift/api v0.0.0-20230414143018-3367bc7e6ac7 //allow-merging | |||
| replace github.com/openstack-k8s-operators/lib-common/modules/common => github.com/auniyal61/lib-common/modules/common v0.0.0-20240904075816-9bde700ea164 | |||
There was a problem hiding this comment.
is this replace line correct?
shoudl it no be a path to the location where zuul clones it to work in this instance.
like fo like ./api line above?
There was a problem hiding this comment.
For us its openstack-k8s-operators/lib-common maybe modules/common is extra, but above also at L15 its written as modules/common.
this is a main repo: github.com/openstack-k8s-operators/lib-common/modules/common
and replace it will this particular commit github.com/auniyal61/lib-common/modules/common v0.0.0-20240904075816-9bde700ea164
github.com/auniyal61/lib-common/modules/common
target commit-hash: 9bde700ea164 ( but this too should itself come with version)
the rest is build version of target commit, but I could not find it in github-page or logs, so not sure from where we get this
v0.0.0-20240904075816.
the above is not be the answer of asked question, just what I understand.
There was a problem hiding this comment.
@SeanMooney both would work. This replace line pulls the commit form @auniyal61's fork for the build. If you know the local path in the env zuul does the build then you can use a replace line the pulls from the local lib-common code if that local lib common code is a clone from @auniyal61's fork.
There was a problem hiding this comment.
so the issue with using github.com/auniyal61/lib-common/modules/common v0.0.0-20240904075816-9bde700ea164
is if you don't update it every time you change the commit in the lib common pr then it wont pull the right thing
in terms of where it will be yes we know that
{{ ansible_user_dir }} is the ci users home directory
so it would be
~/src/github.com/openstack-k8s-operators/lib-common/modules/common
that should work with depend on and actually use the version form the lib common review
|
/retest |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
@auniyal61: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Depends-On: openstack-k8s-operators/lib-common#557