Make certificate generation FIPS compliant #378
Merged
+155
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weinimo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
weinimo
commented
Sep 16, 2024
johnsom
reviewed
Sep 16, 2024
weinimo
force-pushed
the
cert-fips-fix
branch
from
38acf6e
to
34f694f
Compare
Golang's own, deprecated x509.EncryptPEMBlock function uses MD5, which is forbidden in FIPS mode. This change copies the problematic function and modifies it so that it uses SHA256 instead of MD5.
weinimo
force-pushed
the
cert-fips-fix
branch
from
34f694f
to
6f070fe
Compare
weinimo
force-pushed
the
cert-fips-fix
branch
from
6f070fe
to
9e9777c
Compare
This is inspired by [1] (Apache-2.0 license) [1]: https://github.com/smallstep/crypto
weinimo
force-pushed
the
cert-fips-fix
branch
from
9e9777c
to
234d68f
Compare
|
/lgtm tested in non-FIPS env, no regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses PKCS#8 private key encryption now, which is FIPS compliant.
OSPRH-9709
OSPRH-6237