-
Notifications
You must be signed in to change notification settings - Fork 35
Validate unsupported ansible vars #302
Validate unsupported ansible vars #302
Conversation
ansible/ansible-runner#1327 Signed-off-by: Fabricio Aguiar <[email protected]>
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/9ef7e6c7cf494508a65d5cca013bfdfb ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 43s |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if we could check against multiple variables, so we are ready for more surprises.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one, lgtm
are you aware of other variable? I think we can change it once we have more variables to validate |
Not at the time no. But the code could be changed to check against membership in set/list, and print out message with name of the checked variable. Rather than a constant. Search would do the trick, or a map. The best would be https://pkg.go.dev/slices#Contains Any would however give us a clear way to extend this logic. |
In retrospect, I'm not going to hold this back over something that can be a follow up. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, jpodivin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8241beb
into
openstack-k8s-operators:main
ansible-runner does not support ANSIBLE_ENABLE_TASK_DEBUGGER, so when it is on the AEE CR, the playbook gets stuck on error (which affect rescue blocks) - ansible/ansible-runner#1327