Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

Validate unsupported ansible vars #302

Merged

Conversation

fao89
Copy link
Contributor

@fao89 fao89 commented Jan 24, 2024

ansible-runner does not support ANSIBLE_ENABLE_TASK_DEBUGGER, so when it is on the AEE CR, the playbook gets stuck on error (which affect rescue blocks) - ansible/ansible-runner#1327

@openshift-ci openshift-ci bot requested review from olliewalsh and viroel January 24, 2024 18:03
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9ef7e6c7cf494508a65d5cca013bfdfb

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 43s
podified-multinode-edpm-deployment-crc FAILURE in 1h 21m 36s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 23m 36s

@fao89
Copy link
Contributor Author

fao89 commented Jan 25, 2024

recheck

Copy link
Contributor

@jpodivin jpodivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if we could check against multiple variables, so we are ready for more surprises.

Copy link

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, lgtm

@fao89 fao89 requested a review from rebtoor January 31, 2024 11:24
@fao89
Copy link
Contributor Author

fao89 commented Feb 2, 2024

I would prefer if we could check against multiple variables, so we are ready for more surprises.

are you aware of other variable? I think we can change it once we have more variables to validate

@fao89 fao89 requested a review from jpodivin February 6, 2024 14:33
@jpodivin
Copy link
Contributor

jpodivin commented Feb 6, 2024

I would prefer if we could check against multiple variables, so we are ready for more surprises.

are you aware of other variable? I think we can change it once we have more variables to validate

Not at the time no. But the code could be changed to check against membership in set/list, and print out message with name of the checked variable. Rather than a constant.

Search would do the trick, or a map. The best would be https://pkg.go.dev/slices#Contains Any would however give us a clear way to extend this logic.

@jpodivin
Copy link
Contributor

jpodivin commented Feb 7, 2024

In retrospect, I'm not going to hold this back over something that can be a follow up.

Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8241beb into openstack-k8s-operators:main Feb 7, 2024
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants