Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all services in Functional tests #831

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bshephar
Copy link
Contributor

@bshephar bshephar commented Jun 7, 2024

This change enables all of the services in the functional tests. This ensures that each service's code path is executed and should catch any potential issues before services are enabled in integration testing.

Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bshephar
Copy link
Contributor Author

bshephar commented Jun 7, 2024

This will take a bit of work, it needs valid config for each service to validate. But it might be worth doing just to catch things early. Let's discuss before sinking more time into it. But as it stands, services will fail in the tests here because they don't have valid config to parse through their webhooks. Eg:

2024/06/07 12:54:40 http: panic serving 127.0.0.1:57148: runtime error: invalid memory address or nil pointer dereference
goroutine 2608 [running]:
net/http.(*conn).serve.func1()
        /Users/brendanshephard/sdk/go1.21.9/src/net/http/server.go:1868 +0xb0
panic({0x10657bca0?, 0x1078fa060?})
        /Users/brendanshephard/sdk/go1.21.9/src/runtime/panic.go:920 +0x26c
github.com/openstack-k8s-operators/nova-operator/api/v1beta1.(*NovaSpecCore).ValidateCellTemplates(0x140011fbb28, 0x14001b332c0)
        /Users/brendanshephard/go/pkg/mod/github.com/openstack-k8s-operators/nova-operator/[email protected]/v1beta1/nova_webhook.go:156 +0x544
github.com/openstack-k8s-operators/nova-operator/api/v1beta1.(*NovaSpecCore).ValidateCreate(0x140011fbb28, 0x14001b332c0)
        /Users/brendanshephard/go/pkg/mod/github.com/openstack-k8s-operators/nova-operator/[email protected]/v1beta1/nova_webhook.go:239 +0x28
github.com/openstack-k8s-operators/nova-operator/api/v1beta1.(*NovaSpec).ValidateCreate(...)
        /Users/brendanshephard/go/pkg/mod/github.com/openstack-k8s-operators/nova-operator/[email protected]/v1beta1/nova_webhook.go:232
github.com/openstack-k8s-operators/openstack-operator/apis/core/v1beta1.(*OpenStackControlPlane).ValidateCreateServices(0x140011fb000, 0x14001b32de0)
        /Users/brendanshephard/Code/openstack-k8s-operators/openstack-operator/apis/core/v1beta1/openstackcontrolplane_webhook.go:196 +0x2564

@dprince
Copy link
Contributor

dprince commented Jun 13, 2024

additionally, we are going to need to 'Simulate' that each services becomes Ready. The best way to do this seems via test helpers that live in the service operators themselves. Quite a few of those will need to be exposed or implemented here.

Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This change enables all of the services in the functional tests.
This ensures that each service's code path is executed and should catch any potential
issues before services are enabled in integration testing.

Signed-off-by: Brendan Shephard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants