-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable all services in Functional tests #831
base: main
Are you sure you want to change the base?
Enable all services in Functional tests #831
Conversation
Skipping CI for Draft Pull Request. |
This will take a bit of work, it needs valid config for each service to validate. But it might be worth doing just to catch things early. Let's discuss before sinking more time into it. But as it stands, services will fail in the tests here because they don't have valid config to parse through their webhooks. Eg:
|
additionally, we are going to need to 'Simulate' that each services becomes Ready. The best way to do this seems via test helpers that live in the service operators themselves. Quite a few of those will need to be exposed or implemented here. |
b1ca4c4
to
75e8bc3
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change enables all of the services in the functional tests. This ensures that each service's code path is executed and should catch any potential issues before services are enabled in integration testing. Signed-off-by: Brendan Shephard <[email protected]>
75e8bc3
to
39d6ce6
Compare
This change enables all of the services in the functional tests. This ensures that each service's code path is executed and should catch any potential issues before services are enabled in integration testing.