Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSPRH-10380] Move dashboards to use go API #494

Conversation

vyzigold
Copy link
Contributor

No description provided.

Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vyzigold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlarriba
Copy link
Collaborator

jlarriba commented Oct 1, 2024

Please, add the jira issue that is being solved in the title of each PR with [] so Jira can make the binding.

I hope that with COO 0.3.1 we also have "Datasource" object to be able to add PrometheusDatasource object via API instead of just spitting plain yaml like we do here: https://github.com/openstack-k8s-operators/telemetry-operator/blob/main/pkg/metricstorage/dashboard_datasource.go#L46-L59

@vyzigold vyzigold changed the title Move dashboards to use go API [OSPRH-10380] Move dashboards to use go API Oct 2, 2024
@vyzigold
Copy link
Contributor Author

vyzigold commented Oct 2, 2024

I added the Jira number to the title. Regarding the Datasource, I also saw that piece of yaml. There is no "Datasource" type in OBO: https://github.com/rhobs/observability-operator/blob/main/pkg/apis/uiplugin/v1alpha1/types.go .

The issue with this yaml is, that it's not actually a CR. This is saved as a ConfigMap: https://github.com/openstack-k8s-operators/telemetry-operator/blob/main/controllers/metricstorage_controller.go#L720

@jlarriba
Copy link
Collaborator

jlarriba commented Oct 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4199ab0 into openstack-k8s-operators:main Oct 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants