Otel implemenation #1181
Open
Otel implemenation #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- apps/checker/go.mod: Language not supported
Comments suppressed due to low confidence (1)
apps/checker/handlers/checker.go:282
- Ensure that the new behavior introduced by the OpenTelemetry integration is covered by tests.
otelShutdown, err := otelOS.SetupOTelSDK(ctx, req.OtelConfig.Endpoint, h.Region, req.OtelConfig.Headers)
apps/checker/handlers/checker.go
Outdated
| fmt.Println(req.OtelConfig.Headers) | ||
|
|
||
| if err != nil { | ||
| fmt.Println("Error setting up otel", err) |
There was a problem hiding this comment.
Inconsistent error handling. Use the 'log' package instead of 'fmt.Println' for logging errors.
Suggested change
| fmt.Println("Error setting up otel", err) | |
| log.Ctx(ctx).Error().Err(err).Msg("Error setting up otel") |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| go run cmd/main.go | ||
| ``` | ||
|
|
||
| you can also set the env variable |
There was a problem hiding this comment.
The phrase "you can also set the env variable" should be corrected to "you can also set the environment variables".
Suggested change
| you can also set the env variable | |
| you can also set the environment variables |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
A picture tells a thousand words (if any)
Before this PR
{Please add a screenshot here}
After this PR
{Please add a screenshot here}
Related Issue (optional)