Write settings on change, fixes #766

openstudiocoalition · Nov 29, 2024 · 82954b4 · 82954b4
1 parent ef255ea
commit 82954b4
Showing 1 changed file with 24 additions and 8 deletions.
diff --git a/src/openstudio_lib/MainWindow.cpp b/src/openstudio_lib/MainWindow.cpp
@@ -302,23 +302,32 @@ bool MainWindow::allowAnalytics() const {
 //}
 
 void MainWindow::toggleUnits(bool displayIP) {
-  m_displayIP = displayIP;
+  if (m_displayIP != displayIP) {
+    m_displayIP = displayIP;
+    writeSettings();
+  }
 }
 
 bool MainWindow::verboseOutput() const {
   return m_verboseOutput;
 }
 
 void MainWindow::toggleVerboseOutput(bool verboseOutput) {
-  m_verboseOutput = verboseOutput;
+  if (m_verboseOutput != verboseOutput) {
+    m_verboseOutput = verboseOutput;
+    writeSettings();
+  }
 }
 
 bool MainWindow::useClassicCLI() const {
   return m_useClassicCLI;
 }
 
 void MainWindow::toggleUseClassicCLI(bool useClassicCLI) {
-  m_useClassicCLI = useClassicCLI;
+  if (m_useClassicCLI != useClassicCLI) {
+    m_useClassicCLI = useClassicCLI;
+    writeSettings();
+  }
 }
 
 bool MainWindow::geometryDiagnostics() const {
@@ -384,7 +393,10 @@ void MainWindow::onVerticalTabSelected(int verticalTabId) {
 }
 
 void MainWindow::toggleGeometryDiagnostics(bool geometryDiagnostics) {
-  m_geometryDiagnostics = geometryDiagnostics;
+  if (m_geometryDiagnostics != geometryDiagnostics) {
+    m_geometryDiagnostics = geometryDiagnostics;
+    writeSettings();
+  }
 }
 
 void MainWindow::promptAnalytics() {
@@ -414,8 +426,10 @@ void MainWindow::toggleAnalytics(bool allowAnalytics) {
 }
 
 void MainWindow::changeLanguage(const QString& rLanguage) {
-  m_currLang = rLanguage;
-  writeSettings();
+  if (m_currLang != rLanguage) {
+    m_currLang = rLanguage;
+    writeSettings();
+  }
 }
 
 void MainWindow::configureProxyClicked() {
@@ -459,8 +473,10 @@ bool MainWindow::displayAdditionalProps() const {
 }
 
 void MainWindow::toggleDisplayAdditionalProps(bool displayAdditionalProps) {
-  m_displayAdditionalProps = displayAdditionalProps;
-  writeSettings();
+  if (m_displayAdditionalProps != displayAdditionalProps) {
+    m_displayAdditionalProps = displayAdditionalProps;
+    writeSettings();
+  }
 }
 
 }  // namespace openstudio