Fix #638 - Make links clickable for measure descriptions #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jmarrec
commented
Nov 8, 2023
jmarrec
commented
- Fix Make links clickable in measure descriptions #638
- Can't think of a side effect making this. We're not worried about phishing attempts
|
Looks like this will open links in the system browser? That seems fine, the measure writer could include malicious links, that would have to be taken care of by some sort of review process. Give that, this seems ok to me |
|
I thought about this, i just think doing phishing via an OpenStudio Measure hosted on BCL would be... surprising :) |
macumber
approved these changes
Nov 12, 2023
|
Agreed :-) Merge away! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.