Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python Measures #651

Merged
merged 13 commits into from
Dec 25, 2023
Merged

Add support for Python Measures #651

merged 13 commits into from
Dec 25, 2023

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Dec 23, 2023

No description provided.

jmarrec
jmarrec commented Dec 23, 2023
View reviewed changes
Copy link
Collaborator Author

@jmarrec jmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm rebasing this older branch, so I don't know if everything is good or not, but I found this adjustments I need to make due to the fact that the 3.7.0 installer has the C++ CLI as default now

src/openstudio_app/OpenStudioApp.cpp Outdated Show resolved Hide resolved
src/openstudio_app/OpenStudioApp.cpp Outdated Show resolved Hide resolved
src/openstudio_lib/ApplyMeasureNowDialog.cpp Outdated Show resolved Hide resolved
@macumber
Copy link
Collaborator

Hey @jmarrec this is cool, my two main questions are:

  1. Do you want to squeeze this in to 1.7.0? If so, we should put it in the RC to get testing

@macumber
Copy link
Collaborator

Hey @jmarrec this is great, my two main questions are:

  1. I think currently develop is using the new CLI for everything right now. Adding options to support the classic CLI will be more work and would have to be removed in a release or two anyway since the classic CLI won't be around forever. My suggestion would be to remove all the options in this PR and just use the new CLI.
  2. Do you want to squeeze this into 1.7.0? If so we should put it into the first RC to get testing on it.

@jmarrec
Copy link
Collaborator Author

jmarrec commented Dec 23, 2023 •
edited
Loading

    1. Yes.
    1. Because everything is still new, i definitely want an option to fall back on the classic CLI. We don't want people to not be able to run their workflows. It's trivial to remove in the future. Basically revert the new option added to this PR. Would take a few minutes only

@macumber macumber merged commit 379b140 into develop Dec 25, 2023
8 checks passed
@macumber macumber deleted the PythonMeasures branch December 25, 2023 04:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@macumber macumber macumber left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmarrec @macumber