-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install openstudio to bin directory so it can be found relative to lib #699
Conversation
@jmarrec this seems like the best thing to do in the short term. We can try to find a better fix later but the layout in the OpenStudio Application install has to match what getOpenStudioCLI is expecting. My thought was we should add an environment variable that the app could use to pass the path into getOpenStudioCLI. Or just check if the current binary is the openstudio CLI and use that.... |
@jmarrec I'll go ahead and merge this tomorrow unless you object |
I don't want to make a copy of the executable. It's big. We should symlink instead. |
Hum, the CLI is only 3 MB now that it doesn't statically link ruby. That's not too bad. but I still went ahead (before I realized it was only 3 MB) and tried to make the symlink approach work. The arm64 build failed, not sure if related. My mac needs a Qt upgrade to build and I'm on slow internet, so I'll try again later today once it's installed. If I can make it work under 30 min, I'll do it, otherwise I'll revert back to your changes. |
I think the right way to fix this would be to move the content of the lib folder into the Mac bundle, the idea is you can move the bundle around and it still works. However, the Mac bundle doesn't use a |
Tested locally on my mac after installing the dmg:
Running the test_os_cli from #695 (comment)
|
@jmarrec this works for me, changes to fully self-contain the bundle would be too high risk right now |
Install openstudio to bin directory so it can be found relative to lib, fixes #695
Basically, the openstudio CLI loads the libs from the lib folder, then getOpenStudioCLI looks for the CLI based on the libs paths.