Fix #162 - Display ScheduleConstant, ScheduleCompact and ScheduleFile #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QColor is constexpr noexcept
The refreshContent is not working 100%, but whatever
… content of only head & tail
jmarrec
force-pushed
the
162_DisplayMoreSchedules
branch
from
574ae4c to
3d72472
Compare
macumber
reviewed
Sep 1, 2024
| model::ScheduleFile(*e_, 1, 1); | ||
| } | ||
| break; | ||
| } |
There was a problem hiding this comment.
@jmarrec can you move the break down one level, right now if you cancel out of the file dialog the switch statement falls through into the default section and calls LOG_FREE_AND_THROW
jmarrec
commented
Sep 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScheduleConstant
Easy peasy
ScheduleFile
Creating is possible, will ask for the external file on disk.
Added a lot of usability there, will display the content of the external file and show what data you're selecting, warn you if not matching, etc
ScheduleCompact
Displaying the object as is. Not possible to create, will tell you to use a ScheduleRuleset instead
Demo