Fix #744 Fix #745 - fixup icon and Can't see QtWebEngine pages on macOS #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jmarrec
commented
Sep 4, 2024
•
jmarrec
commented
- Fix [v1.8.0-rc3] os.icns is outdated #744
- Fix [v1.8.0-rc3] Can't see QtWebEngine pages on macOS #745
…cs.disable-executable-page-protection`
…wasn't there yet)
jmarrec
commented
Sep 4, 2024
icons/os.icns
Outdated
There was a problem hiding this comment.
Generated via
iconutil -c icns os.iconset
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>com.apple.security.cs.disable-executable-page-protection</key> |
There was a problem hiding this comment.
entitlement for QtWebEngineProcess
| @@ -15,7 +15,7 @@ BEGIN | |||
| VALUE "FileDescription", "OpenStudio Application for Energy Modeling\0" | |||
| VALUE "FileVersion", "${OPENSTUDIOAPPLICATION_VERSION}\0" | |||
| VALUE "InternalName", "OpenStudioApp\0" | |||
| VALUE "LegalCopyright", "Copyright (c) 2020-2022, OpenStudio Coalition and other contributors. All rights reserved..\0" | |||
| VALUE "LegalCopyright", "Copyright (c) 2020-${CURRENT_YEAR}, OpenStudio Coalition and other contributors. All rights reserved..\0" | |||
There was a problem hiding this comment.
outdated, never again!
src/openstudio_app/CMakeLists.txt
Outdated
Comment on lines
551
to
561
| install( | ||
| CODE " | ||
| include(\"${CMAKE_CURRENT_FUNCTION_LIST_FILE}\") | ||
| codesign_files_macos( | ||
| FILES \"\${CMAKE_INSTALL_PREFIX}/$<TARGET_BUNDLE_DIR_NAME:${target_name}>/Contents/Frameworks/QtWebEngineCore.framework/Versions/A/Helpers/QtWebEngineProcess.app/Contents/MacOS/QtWebEngineProcess\" | ||
| SIGNING_IDENTITY \"${CPACK_CODESIGNING_DEVELOPPER_ID_APPLICATION}\" | ||
| IDENTIFIER \"${CPACK_CODESIGNING_MACOS_IDENTIFIER}.QtWebEngineProcess\" | ||
| ENTITLEMENTS \"${CMAKE_CURRENT_SOURCE_DIR}/../../cmake/QtWebEngineProcess.entitlements\" | ||
| FORCE VERBOSE | ||
| ) | ||
| " |
There was a problem hiding this comment.
After deep signing OpenStudioApp, specifically sign the QtWebEngineProcess with the entitlement that is apparently needed per https://forum.qt.io/topic/102212/qtwebengine-signing-issues/14
There was a problem hiding this comment.
Ok
$ cat /Users/julien/Qt/6.5.2/macos/lib/QtWebEngineCore.framework/Versions/A/Helpers/QtWebEngineProcess.app/Contents/Resources/QtWebEngineProcess.entitlements
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
<true/>
<key>com.apple.security.cs.disable-library-validation</key>
<true/>
<key>com.apple.security.cs.allow-jit</key>
<true/>
<key>com.apple.security.cs.disable-executable-page-protection</key>
<true/>
</dict>
</plist>
https://doc.qt.io/qt-6/qtwebengine-deploying.html#macos-specific-deployment-steps
|
Ok, Icon is fixed, but still can't see the geometry editor... 
|
jmarrec
commented
Sep 4, 2024
| FILES \"\${CMAKE_INSTALL_PREFIX}/$<TARGET_BUNDLE_DIR_NAME:${target_name}>/Contents/Frameworks/QtWebEngineCore.framework/Versions/A/Helpers/QtWebEngineProcess.app/Contents/MacOS/QtWebEngineProcess\" | ||
| SIGNING_IDENTITY \"${CPACK_CODESIGNING_DEVELOPPER_ID_APPLICATION}\" | ||
| IDENTIFIER \"${CPACK_CODESIGNING_MACOS_IDENTIFIER}.QtWebEngineProcess\" | ||
| ENTITLEMENTS \"${QtWebEngineProcess}/Contents/Resources/QtWebEngineProcess.entitlements\" |
There was a problem hiding this comment.
Grab the entitlements directly from the Qt install dir.
$ cat /Users/julien/Qt/6.5.2/macos/lib/QtWebEngineCore.framework/Versions/A/Helpers/QtWebEngineProcess.app/Contents/Resources/QtWebEngineProcess.entitlements
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
<true/>
<key>com.apple.security.cs.disable-library-validation</key>
<true/>
<key>com.apple.security.cs.allow-jit</key>
<true/>
<key>com.apple.security.cs.disable-executable-page-protection</key>
<true/>
</dict>
</plist>
|
Alright, self pat on the back, moving on 
|
|
Awesome job @jmarrec ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.