Skip to content

Commit

Permalink
style: improve problem panel style (#2727)
Browse files Browse the repository at this point in the history
* style: improve problem panel style

* chore: update linenumber text
  • Loading branch information
erha19 authored May 22, 2023
1 parent 5c09fb5 commit 59245fc
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
1 change: 0 additions & 1 deletion packages/markers/src/browser/markers-tree.view.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ const MarkerList: FC<{ viewState: ViewState }> = ({ viewState }) => {
height={viewState.height}
itemHeight={MARKER_TREE_NODE_HEIGHT}
supportDynamicHeights={true}
overflow={'auto'}
onReady={handleTreeReady}
model={model}
placeholder={() => <Empty />}
Expand Down
2 changes: 1 addition & 1 deletion packages/markers/src/browser/tree/marker-node.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ const MarkerItemDescription: FC<{ marker: IRenderableMarker }> = memo(({ marker
)}
{marker.code && ')'}
</div>
<div className={styles.position}>{`[${marker.startLineNumber},${marker.startColumn}]`}</div>
<div className={styles.position}>{`[Ln ${marker.startLineNumber}, Col ${marker.startColumn}]`}</div>
</div>
);
});
Expand Down
13 changes: 8 additions & 5 deletions packages/markers/src/browser/tree/tree-node.module.less
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,15 @@
.detail_name {
color: var(--foreground);
margin-right: 6px;
display: inline;
white-space: pre;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}

.detail_description {
display: inline;
display: inline-flex;
flex-shrink: 0;
margin-left: 5px;
color: var(--descriptionForeground);
.typeContainer {
Expand Down Expand Up @@ -116,12 +119,12 @@

.overflow_wrap {
flex: 1;
display: flex;
flex-shrink: 0;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
text-align: left;
color: var(--foreground);
flex-direction: row;
width: 0;
}

.flex_wrap {
Expand Down

1 comment on commit 59245fc

@opensumi
Copy link
Contributor

@opensumi opensumi bot commented on 59245fc May 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release Candidate Summary:

Released 🚀 2.24.3-rc-1684723589.0

2.24.3-rc-1684723589.0

user input ref: v2.24

59245fc style: improve problem panel style (#2727)

Please sign in to comment.