RBAC #678
Merged
RBAC #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In doubt, be restrictive. Following patches will add finer grained permissions.
To all publish calls that set a "path" label already. Now we can filter by namespace: $ om node events --filter namespace=test -o yaml at: "2025-01-23T15:58:03.243878075+01:00" data: instance_monitor_update: global_expect: frozen global_expect_options: null local_expect: null orchestration_id: d9fed2b5-0f84-4442-a06b-335316a54c9a state: null labels: namespace: test origin: api path: test/svc/svc1 node: dev2n1 path: test/svc/svc1 id: 0 kind: SetInstanceMonitor ---
Deliver an event with a namespace label only if the user is at least guest on the namespace.
cgalibern
reviewed
Jan 23, 2025
cgalibern
approved these changes
Jan 23, 2025
Instead of doing that for every event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.