Make helpdesk email address and platform URL configurable at runtime #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `Dockerfile` and adapt format used for `platform-app`. - Remove environment variables used at build time (`REACT_APP_`). - The files `src/configuration.js` and `nginx.conf` became obsolete and were therefore removed. - Use `config.helpdeskEmail` for both contact elements in `src/constants.js`. - Add `DEVOPS_CONTEXT_` variables to `public/config.template`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I suggest changes that extend the configurability at runtime, similar to how it works in the Platform front end (
platform-app).Summary of changes:
Dockerfileand adopt format used inplatform-app.REACT_APP_).src/configuration.jsandnginx.confbecame obsolete and were therefore removed.config.helpdeskEmailfor both contact elements insrc/constants.js.DEVOPS_CONTEXT_variables topublic/config.template.I hope you think this is useful.