fix todo comment

opentdf · Mar 20, 2024 · cf9b15a · cf9b15a
1 parent c3daeba
commit cf9b15a
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 10 deletions.
diff --git a/cmd/policy-attributes.go b/cmd/policy-attributes.go
@@ -9,7 +9,7 @@ import (
 	"github.com/spf13/cobra"
 )
 
-// TODO: add metadata to outputs once [https://github.com/opentdf/tructl/issues/30] is addressed
+// TODO: add metadata to outputs once [https://github.com/opentdf/tructl/issues/73] is addressed
 
 var (
 	attrValues                 []string

diff --git a/cmd/policy-namespaces.go b/cmd/policy-namespaces.go
@@ -8,7 +8,7 @@ import (
 	"github.com/spf13/cobra"
 )
 
-// TODO: add metadata to outputs once [https://github.com/opentdf/tructl/issues/30] is addressed
+// TODO: add metadata to outputs once [https://github.com/opentdf/tructl/issues/73] is addressed
 
 var (
 	policy_namespacesCommands = []string{

diff --git a/cmd/policy-resource_mappings.go b/cmd/policy-resource_mappings.go
@@ -9,7 +9,7 @@ import (
 	"github.com/spf13/cobra"
 )
 
-// TODO: add metadata to outputs once [https://github.com/opentdf/tructl/issues/30] is addressed
+// TODO: add metadata to outputs once [https://github.com/opentdf/tructl/issues/73] is addressed
 
 var (
 	policy_resource_mappingsTerms []string

diff --git a/cmd/policy-subject_condition_sets.go b/cmd/policy-subject_condition_sets.go
@@ -1,3 +1 @@
 package cmd
-
-// TODO: add metadata to outputs once [https://github.com/opentdf/tructl/issues/30] is addressed
diff --git a/cmd/policy-subject_mappings.go b/cmd/policy-subject_mappings.go
@@ -10,7 +10,7 @@ import (
 	"github.com/spf13/cobra"
 )
 
-// TODO: add metadata to outputs once [https://github.com/opentdf/tructl/issues/30] is addressed
+// TODO: add metadata to outputs once [https://github.com/opentdf/tructl/issues/73] is addressed
 
 var (
 	policy_subject_mappingsCmds = []string{

diff --git a/pkg/handlers/subjectmappings.go b/pkg/handlers/subjectmappings.go
@@ -40,10 +40,9 @@ func (h Handler) CreateNewSubjectMapping(attrValId string, actions []*policy.Act
 
 func (h Handler) UpdateSubjectMapping(id string, updatedSCSId string, updatedActions []*policy.Action, metadata *common.MetadataMutable, metadataBehavior common.MetadataUpdateEnum) (*policy.SubjectMapping, error) {
 	resp, err := h.sdk.SubjectMapping.UpdateSubjectMapping(h.ctx, &subjectmapping.UpdateSubjectMappingRequest{
-		Id:                    id,
-		SubjectConditionSetId: updatedSCSId,
-		Actions:               updatedActions,
-		// TODO: add reusable metadata label flags and drive this?
+		Id:                     id,
+		SubjectConditionSetId:  updatedSCSId,
+		Actions:                updatedActions,
 		MetadataUpdateBehavior: metadataBehavior,
 		Metadata:               metadata,
 	})