Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creation of Subject Condition Set during simultaneous creation of Subject Mapping #72

Closed
jakedoublev opened this issue Mar 20, 2024 · 0 comments · Fixed by #78
Closed

Allow creation of Subject Condition Set during simultaneous creation of Subject Mapping #72

jakedoublev opened this issue Mar 20, 2024 · 0 comments · Fixed by #78
Assignees
@jakedoublev

Comments

@jakedoublev
Copy link
Contributor

jakedoublev commented Mar 20, 2024 •
edited
Loading

Background

After #67 closing #10, there is a need to allow creation of a Subject Condition Set while a Subject Mapping is being created.

Dependencies

Blocked by: #71

Acceptance Criteria

  1. flags are utilized so that a SCS can be created simultaneously while policy subject-mappings create is invoked
  2. if a new SCS is not created when the SM is created, an existing id is still utilized instead
  3. the user receives an error state if they provide both the SCS id flag and the values to create a new SCS simultaneously on SM create
  4. context about the created SCS is also provided to the user along with the create SM response
@jakedoublev jakedoublev mentioned this issue Mar 20, 2024
Merged
jrschumacher pushed a commit that referenced this issue Mar 20, 2024
@jakedoublev
feat(core): add metadata behavior and fix subject mappings (#67)
acb88cf 
1. adds subject-mappings CRUD back (with only support at first for creating a Subject Mapping with a known, existing Subject Condition Set Id at least until SCS functionality is added to the CLI as well)
2. adds consistent universal string slice `--label` flag to Policy Object CREATE flows for metadata creation
3. adds consistent universal string slice `--label` and a boolean `--force-replace-labels` to drive update behavior in Policy Object UPDATE flows for metadata update (i.e. `policy <policy object> update --label key1=value1 --label key2=value2 --force-replace-labels` overwrites all labels with a new map containing just `key1` and `key2`)

Partially addresses: #60
Related to: #72
Closes: #10
@jakedoublev jakedoublev added 🛑 blocked Blocked and removed 🛑 blocked Blocked labels Mar 25, 2024
@jakedoublev jakedoublev self-assigned this Mar 26, 2024
@jrschumacher jrschumacher linked a pull request Mar 28, 2024 that will close this issue
feat(core): subject condition set CLI CRUD #78
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakedoublev jakedoublev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): subject condition set CLI CRUD opentdf/otdfctl
1 participant
@jakedoublev