Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): fix subject-mappings in the CLI and add consistent metadata create/update behavior throughout #67

Merged
merged 15 commits into from
Mar 20, 2024

Conversation

jakedoublev
Copy link
Contributor

@jakedoublev jakedoublev commented Mar 14, 2024

  1. adds subject-mappings CRUD back (with only support at first for creating a Subject Mapping with a known, existing Subject Condition Set Id at least until SCS functionality is added to the CLI as well)
  2. adds consistent universal string slice --label flag to Policy Object CREATE flows for metadata creation
  3. adds consistent universal string slice --label and a boolean --force-replace-labels to drive update behavior in Policy Object UPDATE flows for metadata update (i.e. policy <policy object> update --label key1=value1 --label key2=value2 --force-replace-labels overwrites all labels with a new map containing just key1 and key2)

Partially addresses: #60
Related to: #72
Closes: #10

cmd/dev.go Outdated Show resolved Hide resolved
@jakedoublev jakedoublev marked this pull request as draft March 19, 2024 16:50
@jakedoublev jakedoublev marked this pull request as ready for review March 19, 2024 18:24
@jakedoublev jakedoublev changed the title feat(subject mappings & metadata): fix subject-mappings in the CLI and add consistent metadata create/update behavior throughout feat(core): fix subject-mappings in the CLI and add consistent metadata create/update behavior throughout Mar 20, 2024
@jrschumacher jrschumacher merged commit acb88cf into main Mar 20, 2024
6 checks passed
@jrschumacher jrschumacher deleted the feat/subject-mappings branch March 20, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLI subject-mapping-conditions CRUD commands
2 participants