[utils] update SuccessOrExit for error tracking #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtdkp
force-pushed
the
code-utils
branch
2 times, most recently
from
b1afbed
to
d3ba580
Compare
zhanglongxia
reviewed
Jul 3, 2023
This commit updates the `SuccessOrExit` macro to accept an action
before goto "exit". It allows us to add a log when error happens.
For example, we can write:
```
SuccessOrExit((error = writeDatasetToSettings()), otbrLogErr("Failed to
write dataset to settings"));
```
So that we know exactly which step a method fails at.
------
This commit also prints the error/status code for macro `SuccessOrDie`.
It looks like the latest openwrt/sdk docker image has dramatic changes that the openwrt CI tests can't build anymore. An example failure can be found here: https://github.com/openthread/ot-br-posix/actions/runs/5443907241/jobs/9901033612
bukepo
approved these changes
Jul 4, 2023
bukepo
reviewed
Jul 4, 2023
|
@jwhui When merging this PR, please merge the two commits separately. The second one is for fixing the broken openwrt CI tests |
jwhui
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
SuccessOrExitmacro to accept an action before goto "exit". It allows us to add a log when error happens. For example, we can write:So that we know exactly which step a method fails at.
This commit also prints the error/status code for macro
SuccessOrDie.