Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dbus] change info logs of property handler to debug #1941

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[dbus] change info logs of property handler to debug #1941

merged 1 commit into from
Jul 18, 2023

Conversation

Irving-cl
Copy link
Contributor

Currently each time dbus property handler is called, there will be a log.
This will cause flooding log when the dbus client is doing polling:

2023-02-26 11:45:47.084  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.085  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.DeviceRole
2023-02-26 11:45:47.109  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.109  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.LinkMode
2023-02-26 11:45:47.115  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.115  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.Channel
2023-02-26 11:45:47.124  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.125  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.CcaFailureRate
2023-02-26 11:45:47.162  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.162  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.RadioTxPower
2023-02-26 11:45:47.197  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.197  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.LinkCounters
2023-02-26 11:45:47.245  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.253  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.Ip6Counters
2023-02-26 11:45:47.282  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.283  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.Rloc16
2023-02-26 11:45:47.324  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.324  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.RouterID
2023-02-26 11:45:47.336  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.336  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.NeighborTable
2023-02-26 11:45:47.350  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.355  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.ChildTable
2023-02-26 11:45:47.389  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.389  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.LeaderData
2023-02-26 11:45:47.404  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.406  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.LocalLeaderWeight
2023-02-26 11:45:47.418  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.418  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.PartitionID
2023-02-26 11:45:47.443  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.443  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.NetworkData
2023-02-26 11:45:47.469  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.469  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.StableNetworkData
2023-02-26 11:45:47.480  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.480  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.ExtendedAddress
2023-02-26 11:45:47.490  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.491  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.InstantRssi
2023-02-26 11:45:47.512  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.512  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.ExtPanId
2023-02-26 11:45:47.528  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.528  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.SrpServerInfo
2023-02-26 11:45:47.558  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.558  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.DnssdCounters
2023-02-26 11:45:47.584  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:45:47.584  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.MdnsTelemetryInfo
2023-02-26 11:45:47.601  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method io.openthread.BorderRouter.GetProperties
2023-02-26 11:47:48.415  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get
2023-02-26 11:47:48.415  9117  9117 I otbr-agent: [INFO]-DBUS----: GetProperty io.openthread.BorderRouter.DeviceRole
2023-02-26 11:47:48.428  9117  9117 I otbr-agent: [INFO]-DBUS----: Handling method org.freedesktop.DBus.Properties.Get

This PR removes these logs.

@zhanglongxia
Copy link
Contributor

Will changing the log level to Debug resolves the issue?

@Irving-cl Irving-cl force-pushed the remove_dbus_log branch 3 times, most recently from 1d814f5 to 343dcdd Compare July 17, 2023 12:10
@Irving-cl Irving-cl changed the title [dbus] remvoe info logs for property handler [dbus] change info logs of property handler to debug Jul 17, 2023
@Irving-cl
Copy link
Contributor Author

Will changing the log level to Debug resolves the issue?

SGTM. Update the log to debug.

abtink
abtink approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

zhanglongxia
zhanglongxia approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@zhanglongxia zhanglongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwhui jwhui merged commit dac9a94 into openthread:main Jul 18, 2023
31 checks passed
@Irving-cl Irving-cl deleted the remove_dbus_log branch August 22, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhanglongxia zhanglongxia zhanglongxia approved these changes

@jwhui jwhui jwhui approved these changes

@abtink abtink abtink approved these changes

Assignees
No one assigned
Labels
comp: logging P4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Irving-cl @zhanglongxia @jwhui @abtink