Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ncp] integrate netif multicast address subscription #2498

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Irving-cl
Copy link
Contributor

This PR integrates the netif multicast address subscirption update with the NCP.

With this PR, applications can listen to a multicast address on wpan interface and receive multicast messages from the Thread network.

The implementation of NcpSpinel::Ip6MulAddrUpdateSubscription uses SPINEL_CMD_PROP_VALUE_INSERT and REMOVE. This PR extends NcpSpinel to support using these commands.

It's a little hard to add an integration test for this. Because there isn't any native tools to easily listen on a multicast address and check what has received. I've verified it locally with a simple c++ program.
Screenshot 2024-09-19 at 18 14 26

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 3.17460% with 61 lines in your changes missing coverage. Please review.

Project coverage is 45.48%. Comparing base (2b41187) to head (6b4e893).
Report is 809 commits behind head on main.

Files with missing lines Patch % Lines
src/ncp/ncp_spinel.cpp 0.00% 54 Missing ⚠️
src/ncp/posix/netif.cpp 22.22% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2498       +/-   ##
===========================================
- Coverage   55.77%   45.48%   -10.30%     
===========================================
  Files          87      100       +13     
  Lines        6890    11875     +4985     
  Branches        0      870      +870     
===========================================
+ Hits         3843     5401     +1558     
- Misses       3047     6181     +3134     
- Partials        0      293      +293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ncp/ncp_spinel.cpp Outdated Show resolved Hide resolved
src/ncp/ncp_spinel.cpp Outdated Show resolved Hide resolved
src/ncp/posix/netif.cpp Outdated Show resolved Hide resolved
src/ncp/posix/netif.cpp Outdated Show resolved Hide resolved
src/ncp/posix/netif.cpp Show resolved Hide resolved
@Irving-cl Irving-cl force-pushed the integrate_ncp_netif_muladdr_sub branch from 191140a to 460821c Compare September 20, 2024 05:54
Copy link
Contributor

@sunytt sunytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@jwhui jwhui merged commit dd261f0 into openthread:main Sep 25, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants