-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ncp] integrate netif multicast address subscription #2498
[ncp] integrate netif multicast address subscription #2498
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2498 +/- ##
===========================================
- Coverage 55.77% 45.48% -10.30%
===========================================
Files 87 100 +13
Lines 6890 11875 +4985
Branches 0 870 +870
===========================================
+ Hits 3843 5401 +1558
- Misses 3047 6181 +3134
- Partials 0 293 +293 ☔ View full report in Codecov by Sentry. |
191140a
to
460821c
Compare
460821c
to
6b4e893
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
This PR integrates the netif multicast address subscirption update with the NCP.
With this PR, applications can listen to a multicast address on wpan interface and receive multicast messages from the Thread network.
The implementation of
NcpSpinel::Ip6MulAddrUpdateSubscription
usesSPINEL_CMD_PROP_VALUE_INSERT
and REMOVE. This PR extends NcpSpinel to support using these commands.It's a little hard to add an integration test for this. Because there isn't any native tools to easily listen on a multicast address and check what has received. I've verified it locally with a simple c++ program.