fix: prevent crash on combatBlockHit #2650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlospess0a
changed the title
…r/canary into fix_crash_combatblock
dudantas
reviewed
May 24, 2024
| @@ -6481,13 +6483,13 @@ bool Game::combatBlockHit(CombatDamage &damage, std::shared_ptr<Creature> attack | |||
| CombatParams damageReflectedParams; | |||
|
|
|||
| BlockType_t primaryBlockType, secondaryBlockType; | |||
| std::shared_ptr<Player> targetPlayer = target->getPlayer(); | |||
| std::shared_ptr<Player> targetPlayer = target ? target->getPlayer() : nullptr; | |||
There was a problem hiding this comment.
You can move this to the line 6463 and avoid nesting the if
dudantas
reviewed
May 24, 2024
Comment on lines
+6463
to
+6470
| if (target) { | ||
| if (std::shared_ptr<Player> targetPlayer = target->getPlayer()) { | ||
| auto chance = targetPlayer->getDodgeChance(); | ||
| if (chance > 0 && uniform_random(0, 10000) < chance) { | ||
| InternalGame::sendBlockEffect(BLOCK_DODGE, damage.primary.type, target->getPosition(), attacker); | ||
| targetPlayer->sendTextMessage(MESSAGE_ATTENTION, "You dodged an attack."); | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (target) { | |
| if (std::shared_ptr<Player> targetPlayer = target->getPlayer()) { | |
| auto chance = targetPlayer->getDodgeChance(); | |
| if (chance > 0 && uniform_random(0, 10000) < chance) { | |
| InternalGame::sendBlockEffect(BLOCK_DODGE, damage.primary.type, target->getPosition(), attacker); | |
| targetPlayer->sendTextMessage(MESSAGE_ATTENTION, "You dodged an attack."); | |
| return true; | |
| } | |
| const auto &targetPlayer = target ? target->getPlayer() : nullptr; | |
| // Skill dodge (ruse) | |
| if (targetPlayer) { | |
| auto chance = targetPlayer->getDodgeChance(); | |
| if (chance > 0 && uniform_random(0, 10000) < chance) { | |
| InternalGame::sendBlockEffect(BLOCK_DODGE, damage.primary.type, target->getPosition(), attacker); | |
| targetPlayer->sendTextMessage(MESSAGE_ATTENTION, "You dodged an attack."); | |
| return true; | |
| } | |
| } |
dudantas
changed the title
|
Do you intend to finish this PR? |
|
Update your pull request and use the pull request template. |
|
i'm closing this pull request due to inactivity. Feel free to reopen when you decide to finish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.