perf: optimized moveCreature and spectators #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beats-dh
approved these changes
Jun 13, 2024
dudantas
approved these changes
Jun 15, 2024
dudantas
pushed a commit
that referenced
this pull request
Nov 10, 2024
As per this PR: #2667 useCacheMap has been disabled, but the code is still there just for decoration, so this PR will remove all that code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In moveCreature, a check was added so that the spectator's search is not called twice, now only one position is passed with the interval adjusted to assume both positions as if it were.
In spectators we no longer use vector_set but just vector and if there is a need to remove record duplication, it will use unordered_set passing the vector in the constructor which is much faster.
Why was useCacheMap disabled?
As the map cache is done synchronously for each movement that a monster makes, it is better to disable it,
as the pathfinder, which is one of the resources that uses this cache the most,
is multithreding and thus the processing cost is divided between the threads.