Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opentelemetry linker error #2678

Conversation

miah-sebastian
Copy link
Contributor

@miah-sebastian miah-sebastian commented Jun 4, 2024

Description

I couldn't compile on Windows 10 without including this package in vcpkg.

Fixes

Fixes linker error #2673

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

It compiles now and it wouldn't compile before.

Test Configuration:

  • Server Version: latest
  • Client: 13.32
  • Operating System: Windows 10

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@miah-sebastian miah-sebastian changed the title Fix opentelemetry linker error #2673 Fix opentelemetry linker error Jun 4, 2024
@majestyotbr majestyotbr changed the title Fix opentelemetry linker error fix: opentelemetry linker error Jun 4, 2024
@majestyotbr majestyotbr merged commit 2db5fee into opentibiabr:main Jun 4, 2024
17 checks passed
@majestyotbr majestyotbr linked an issue Jun 4, 2024 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1>LINK : fatal error LNK1181: cannot open input file 'opentelemetry_common.lib'
3 participants