Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust character limit for player names #3174

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

pudimtibia
Copy link
Contributor

@pudimtibia pudimtibia commented Dec 12, 2024

Description

During some tests I identified that, when the player had a very long name, some features did not work correctly, such as Exura Sio, Exiva, AddSkill.

Names with more than 20 characters currently return an error when instantiating Player(), this fix aims to adjust the character limit to the limit corresponding to the global one.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

@FelipePaluco FelipePaluco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work!

@majestyotbr majestyotbr merged commit 4023def into opentibiabr:main Dec 31, 2024
32 checks passed
vllworldbuilding pushed a commit to vllworldbuilding/canary that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants