fix: preserve decimal precision for skill percentage calculation #3207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where skill progress percentages were being rounded to the nearest integer, resulting in a loss of precision. The
newPercent
variable inaddSkillAdvance
was changed fromuint32_t
todouble_t
to retain decimal values. This ensures accurate feedback for players regarding their skill progress.Behaviour
Actual
When skill progress increases, the displayed percentage is rounded to the nearest integer (e.g., 93.24% was shown as 93%).
Expected
When skill progress increases, the displayed percentage should include decimal values (e.g., 93.24% is shown as 93.24%).
skill-percent-decimal-progress.mp4
Fixes #2430
Type of change
How Has This Been Tested
This change was tested by simulating skill progress updates in the game. Logs were used to verify that the percentage now retains decimal values. The issue was resolved when the correct percentage (e.g., 93.24%) was displayed instead of a rounded integer.
Test Configuration:
Checklist