fix: add null check for moveFunction to prevent crashes #3213
+16
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a null check for the
moveFunction
in theMoveEvent::fireAddRemItem
method. Previously, the code accessedmoveFunction
directly without verifying its validity, which could lead to crashes if it wasnullptr
. The fix ensures stability by:moveFunction
is null.This change improves the reliability of the function, particularly in scenarios where
moveFunction
might not be properly initialized.Behaviour
Actual
moveFunction
without checking if it is null could lead to crashes when it was uninitialized or invalid.Expected
moveFunction
is null, the code logs an error and exits early, preventing crashes.Type of change
How Has This Been Tested
moveFunction
is null to ensure the error is logged and execution stops without crashing.moveFunction
to confirm expected behavior is preserved.Checklist