Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: soul pit arena/animus mastery/soul core #3230

Open
wants to merge 91 commits into
base: main
Choose a base branch
from
Open

Conversation

FelipePaluco
Copy link
Contributor

@FelipePaluco FelipePaluco commented Jan 8, 2025

Description

DO NOT BUT IF ITS FREE. PLAYERS CARE ABOUT QUALITY NOT ABOUT EXCLUSIVITY.

This PR aim's to implement SoulPit fighting arena along with Animus Mastery Logic.

Huge thanks and gratitude to @phacUFPE for co-working and thinking together with me on this implementation since the beginning.

Behaviour

Actual

We don't have soulpit mechanics implemented.

Expected

Soul Pit Mechanic implemented.

For further informatin, please take a time to read:
https://tibia.fandom.com/wiki/Soulpit

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Try to drop some Soul Core of fiendish monsters.
  • Offer the Soul Core to the Obelisk inside Soulpit entrance
  • Fight and see if you animus mastery has increased.
  • Check if a bonus % of exp is added when killing the creature

Test Configuration:

  • Server Version: 13.40
  • Client: 13.40
  • Operating System: N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@FelipePaluco FelipePaluco force-pushed the feat/soulpit branch 3 times, most recently from b96c7e8 to 195c2e4 Compare January 8, 2025 21:42
@paczielny
Copy link

When unlocking any creature in the bestiary, the cyclopedia shows as if the core has already been unlocked, when only the creatures from which the cores were made should do so.
image
image
image

@kaleohanopahala
Copy link
Contributor

Good One 👯

@dudantas dudantas changed the title feat: Soul Pit Arena, Animus Mastery, Soul Core feat: soul pit arena/animus mastery/soul core Jan 10, 2025
@fugu320
Copy link

fugu320 commented Jan 15, 2025

After merging this pull request and compiling, the server crashes when a player steps onto fields with conditions, even outside of the Soulpit.

@XmasGame
Copy link

I compiled on Windows and it works, everything works fine.
But when I compile on Linux when I enter with the character the server crashes

-grettings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants